Re: Reshuffle PTransform Design Doc

2023-10-04 Thread Robert Burke
LGTM. It looks the Go SDK already adheres to these semantics as well for the reference impl(well, reshuffle/redistribute_randomly, _by_key isn't implemented in the Go SDK, and only uses the existing unqualified reshuffle URN [0]. The original strategy, and then for every element, the original

Re: [ANNOUNCE] New PMC Member: Alex Van Boxel

2023-10-04 Thread Chamikara Jayalath
Congrats Alex! On Wed, Oct 4, 2023 at 1:43 AM Jan Lukavský wrote: > Congrats Alex! > On 10/4/23 10:29, Alexey Romanenko wrote: > > Congrats Alex, very well deserved! > > — > Alexey > > On 4 Oct 2023, at 00:38, Austin Bennett > wrote: > > Thanks for all you do, @Alex Van Boxel ! > > On Tue,

Re: [ANNOUNCE] New PMC Member: Robert Burke

2023-10-04 Thread Chamikara Jayalath
Congrats Rebo! On Wed, Oct 4, 2023 at 1:42 AM Jan Lukavský wrote: > Congrats Robert! > On 10/4/23 10:29, Alexey Romanenko wrote: > > Congrats Robert, very well deserved! > > — > Alexey > > On 4 Oct 2023, at 00:39, Austin Bennett > wrote: > > Thanks for all you do @Robert Burke ! > > On Tue,

Re: [ANNOUNCE] New PMC Member: Valentyn Tymofieiev

2023-10-04 Thread Chamikara Jayalath
Congrats Valentyn! On Wed, Oct 4, 2023 at 1:42 AM Jan Lukavský wrote: > Congrats Valentyn! > On 10/4/23 10:26, Alexey Romanenko wrote: > > Congrats Valentyn, very well deserved! > > — > Alexey > > On 4 Oct 2023, at 00:39, Austin Bennett > wrote: > > Thanks for everything @Valentyn Tymofieiev

Re: [VOTE] Release 2.51.0, release candidate #1

2023-10-04 Thread Bruno Volpato via dev
+1 (non-binding). Tested with https://github.com/GoogleCloudPlatform/DataflowTemplates (Java SDK 11, Dataflow Runner using both legacy and v2). Thanks Kenn! On Wed, Oct 4, 2023 at 3:03 PM Robert Bradshaw via dev wrote: > +1 (binding) > > Verified artifacts and signatures and tested a simple

Re: [VOTE] Release 2.51.0, release candidate #1

2023-10-04 Thread Robert Bradshaw via dev
+1 (binding) Verified artifacts and signatures and tested a simple python pipeline in a fresh environment with a wheel. On Wed, Oct 4, 2023 at 8:05 AM Ritesh Ghorse via dev wrote: > +1 (non-binding) validated Go SDK quickstart and Python Streaming > quickstart on Dataflow runner. > > Thanks! >

Re: [QUESTION] Why no auto labels?

2023-10-04 Thread Byron Ellis via dev
This feels like something that maybe should be more explicit? Overloading the transform name to provide a unique stable id feels like perhaps too much magic... also maybe feels like this is leaking specific runner behavior? I get that it's convenient On Wed, Oct 4, 2023 at 9:16 AM Robert Bradshaw

Re: [QUESTION] Why no auto labels?

2023-10-04 Thread Robert Bradshaw via dev
BeamJava and BeamPython have the exact same behavior: transform names within must be distinct [1]. This is because we do not necessarily know at pipeline construction time if the pipeline will be streaming or batch, or if it will be updated in the future, so the decision was made to impose this

Re: [VOTE] Release 2.51.0, release candidate #1

2023-10-04 Thread Ritesh Ghorse via dev
+1 (non-binding) validated Go SDK quickstart and Python Streaming quickstart on Dataflow runner. Thanks! On Tue, Oct 3, 2023 at 5:40 PM XQ Hu via dev wrote: > +1 (non-binding). Tested the simple dataflow ML starter job with >

Re: [QUESTION] Why no auto labels?

2023-10-04 Thread Joey Tran
Cross posting this thread to dev@ to see if this is intentional behavior or if it's something worth changing for the python SDK On Tue, Oct 3, 2023, 10:10 PM XQ Hu via user wrote: > That suggests the default label is created as that, which indeed causes > the duplication error. > > On Tue, Oct

Beam High Priority Issue Report (44)

2023-10-04 Thread beamactions
This is your daily summary of Beam's current high priority issues that may need attention. See https://beam.apache.org/contribute/issue-priorities for the meaning and expectations around issue priorities. Unassigned P1 Issues: https://github.com/apache/beam/issues/28811 [Failing Test]:

Re: [ANNOUNCE] New PMC Member: Robert Burke

2023-10-04 Thread Jan Lukavský
Congrats Robert! On 10/4/23 10:29, Alexey Romanenko wrote: Congrats Robert, very well deserved! — Alexey On 4 Oct 2023, at 00:39, Austin Bennett wrote: Thanks for all you do @Robert Burke  ! On Tue, Oct 3, 2023 at 12:53 PM Ahmed Abualsaud wrote: Congrats

Re: [ANNOUNCE] New PMC Member: Valentyn Tymofieiev

2023-10-04 Thread Jan Lukavský
Congrats Valentyn! On 10/4/23 10:26, Alexey Romanenko wrote: Congrats Valentyn, very well deserved! — Alexey On 4 Oct 2023, at 00:39, Austin Bennett wrote: Thanks for everything @Valentyn Tymofieiev  ! On Tue, Oct 3, 2023 at 12:53 PM Ahmed Abualsaud wrote:

Re: [ANNOUNCE] New PMC Member: Alex Van Boxel

2023-10-04 Thread Jan Lukavský
Congrats Alex! On 10/4/23 10:29, Alexey Romanenko wrote: Congrats Alex, very well deserved! — Alexey On 4 Oct 2023, at 00:38, Austin Bennett wrote: Thanks for all you do, @Alex Van Boxel  ! On Tue, Oct 3, 2023 at 12:50 PM Ahmed Abualsaud via dev wrote:

Re: [ANNOUNCE] New PMC Member: Alex Van Boxel

2023-10-04 Thread Alexey Romanenko
Congrats Alex, very well deserved! — Alexey > On 4 Oct 2023, at 00:38, Austin Bennett wrote: > > Thanks for all you do, @Alex Van Boxel ! > > On Tue, Oct 3, 2023 at 12:50 PM Ahmed Abualsaud via dev > wrote: >> Congratulations! >>

Re: [ANNOUNCE] New PMC Member: Robert Burke

2023-10-04 Thread Alexey Romanenko
Congrats Robert, very well deserved! — Alexey > On 4 Oct 2023, at 00:39, Austin Bennett wrote: > > Thanks for all you do @Robert Burke ! > > On Tue, Oct 3, 2023 at 12:53 PM Ahmed Abualsaud > wrote: >> Congrats Rebo! >> >> On

Re: [ANNOUNCE] New PMC Member: Valentyn Tymofieiev

2023-10-04 Thread Alexey Romanenko
Congrats Valentyn, very well deserved! — Alexey > On 4 Oct 2023, at 00:39, Austin Bennett wrote: > > Thanks for everything @Valentyn Tymofieiev ! > > On Tue, Oct 3, 2023 at 12:53 PM Ahmed Abualsaud > wrote: >> Congrats