+1 (non-binding) Tested on Java IO load tests ( https://github.com/bvolpato/DataflowTemplates/tree/56d18a31c1c95e58543d7a1656bd83d7e859b482/it) BigQueryIO, TextIO, BigtableIO, SpannerIO on Dataflow legacy runner and runner v2
On Fri, Oct 6, 2023 at 3:23 PM Kenneth Knowles <k...@apache.org> wrote: > Additionally we need https://github.com/apache/beam/pull/28665/files in > order to run GHA tests. > > On Fri, Oct 6, 2023 at 3:19 PM Kenneth Knowles <k...@apache.org> wrote: > >> That PR was prior to many cherry-picks so it is not the signal we need. I >> have updated it to the tip of the release-2.51.0 branch. >> >> There were some post-commit tests involving JPMS that I believe need >> https://github.com/apache/beam/pull/28726 to pass. >> >> Kenn >> >> On Fri, Oct 6, 2023 at 2:53 PM Valentyn Tymofieiev via dev < >> dev@beam.apache.org> wrote: >> >>> > PR to run tests against release branch [12]. >>> >>> https://github.com/apache/beam/pull/28663 is closed and test signal is >>> no longer available. did all the tests pass? >>> >>> On Fri, Oct 6, 2023 at 5:32 AM Alexey Romanenko < >>> aromanenko....@gmail.com> wrote: >>> >>>> +1 (binding) >>>> >>>> — >>>> Alexey >>>> >>>> > On 5 Oct 2023, at 18:38, Jean-Baptiste Onofré <j...@nanthrax.net> >>>> wrote: >>>> > >>>> > +1 (binding) >>>> > >>>> > Thanks ! >>>> > Regards >>>> > JB >>>> > >>>> > On Tue, Oct 3, 2023 at 7:58 PM Kenneth Knowles <k...@apache.org> >>>> wrote: >>>> >> >>>> >> Hi everyone, >>>> >> >>>> >> Please review and vote on the release candidate #1 for the version >>>> 2.51.0, as follows: >>>> >> >>>> >> [ ] +1, Approve the release >>>> >> [ ] -1, Do not approve the release (please provide specific comments) >>>> >> >>>> >> Reviewers are encouraged to test their own use cases with the >>>> release candidate, and vote +1 if no issues are found. Only PMC member >>>> votes will count towards the final vote, but votes from all community >>>> members is encouraged and helpful for finding regressions; you can either >>>> test your own use cases or use cases from the validation sheet [10]. >>>> >> >>>> >> The complete staging area is available for your review, which >>>> includes: >>>> >> >>>> >> GitHub Release notes [1], >>>> >> the official Apache source release to be deployed to dist.apache.org >>>> [2], which is signed with the key with fingerprint FFFFFFFF [3], >>>> >> all artifacts to be deployed to the Maven Central Repository [4], >>>> >> source code tag "v1.2.3-RC3" [5], >>>> >> website pull request listing the release [6], the blog post [6], and >>>> publishing the API reference manual [7]. >>>> >> Java artifacts were built with Gradle GRADLE_VERSION and >>>> OpenJDK/Oracle JDK JDK_VERSION. >>>> >> Python artifacts are deployed along with the source release to the >>>> dist.apache.org [2] and PyPI[8]. >>>> >> Go artifacts and documentation are available at pkg.go.dev [9] >>>> >> Validation sheet with a tab for 1.2.3 release to help with >>>> validation [10]. >>>> >> Docker images published to Docker Hub [11]. >>>> >> PR to run tests against release branch [12]. >>>> >> >>>> >> The vote will be open for at least 72 hours. It is adopted by >>>> majority approval, with at least 3 PMC affirmative votes. >>>> >> >>>> >> For guidelines on how to try the release in your projects, check out >>>> our blog post at https://beam.apache.org/blog/validate-beam-release/. >>>> >> >>>> >> Thanks, >>>> >> Kenn >>>> >> >>>> >> [1] https://github.com/apache/beam/milestone/15 >>>> >> [2] https://dist.apache.org/repos/dist/dev/beam/2.51.0 >>>> >> [3] https://dist.apache.org/repos/dist/release/beam/KEYS >>>> >> [4] >>>> https://repository.apache.org/content/repositories/orgapachebeam-1356/ >>>> >> [5] https://github.com/apache/beam/tree/v2.51.0-RC1 >>>> >> [6] https://github.com/apache/beam/pull/28800 >>>> >> [7] https://github.com/apache/beam-site/pull/649 >>>> >> [8] https://pypi.org/project/apache-beam/2.51.0rc1/ >>>> >> [9] >>>> https://pkg.go.dev/github.com/apache/beam/sdks/v2@v2.51.0-RC1/go/pkg/beam >>>> >> [10] >>>> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=437054928 >>>> >> [11] https://hub.docker.com/search?q=apache%2Fbeam&type=image >>>> >> [12] https://github.com/apache/beam/pull/28663 >>>> >>>>
