Re: Streaming model updates for the RunInference transform.

2022-11-22 Thread Andy Ye via dev
Left some comments. Thanks for this proposal Anand! On Mon, Nov 21, 2022 at 4:22 PM Danny McCormick via dev wrote: > Thanks for the writeup Anand, this looks like a good approach. > > > There is a *WIP >

Re: [ANNOUNCE] New committer: Yi Hu

2022-11-11 Thread Andy Ye via dev
Great job Yi! On Fri, Nov 11, 2022 at 4:22 PM Ahmet Altay via dev wrote: > Congratulations Yi! > > On Fri, Nov 11, 2022 at 1:57 PM Chamikara Jayalath via dev < > dev@beam.apache.org> wrote: > >> Contrats Yi! >> >> On Thu, Nov 10, 2022 at 10:48 AM Kerry Donny-Clark via dev < >>

Re: [ANNOUNCE] New committer: Ritesh Ghorse

2022-11-04 Thread Andy Ye via dev
Congrats Ritesh! On Fri, Nov 4, 2022 at 9:26 AM Kerry Donny-Clark via dev < dev@beam.apache.org> wrote: > Congratulations Ritesh, I'm happy to see your hard work and community > spirit recognized! > > On Fri, Nov 4, 2022 at 10:16 AM Jack McCluskey via dev < > dev@beam.apache.org> wrote: > >>

Re: Avoid breaking change when adding an additional parameter to the RunInference PTransform

2022-09-30 Thread Andy Ye via dev
Thanks Anand! I think following this framework will help developers create ModelHandlers with fewer pitfalls, especially for specialized frameworks like XGBoost that support a unique set of params for predict(). On Thu, Sep 29, 2022 at 11:16 AM Danny McCormick via dev < dev@beam.apache.org>

Re: Pass Custom namespaces to RunInference metrics

2022-09-12 Thread Andy Ye via dev
Thanks Anand for the great summary! I'm leaning towards (solution 1) to allow users to pass in a custom namespace for full user control. If there needs to be a certain grouping or ordering of the metrics, the onus should be on the user to add an appropriate grouping prefix such as 'RunInference_'

Re: Benchmark tests for the Beam RunInference API

2022-08-23 Thread Andy Ye via dev
Appreciate the super clear summary of the different benchmark experiments! This will add lots of value to potential users, especially when we integrate GPU benchmarks. Thanks Anand! Best, Andy On Thu, Aug 18, 2022 at 10:22 AM Danny McCormick via dev < dev@beam.apache.org> wrote: > I left a few

Re: Design Doc for Controlling Batching in RunInference

2022-08-19 Thread Andy Ye via dev
terized > by size. > > > > Brian > > > > > > [1] > https://github.com/apache/beam/blob/master/sdks/python/apache_beam/typehints/batch.py > > [2] > https://github.com/apache/beam/blob/3173b503beaf30c4d32a4a39c709fd81e8161907/sdks/python/apache_beam/ty

Design Doc for Controlling Batching in RunInference

2022-08-12 Thread Andy Ye via dev
Hi everyone, I've written up a design doc [1] on controlling batching in RunInference. I'd appreciate any feedback. Thanks! Summary: Add a custom stacking function to RunInference to enable users to control