Re: [BEAM-9015] Adding pyXX-cloud instead of pyXX-gcp and pyXX-aws

2020-01-15 Thread Udi Meiri
We would like to run unit tests using these dependencies (gcp+aws) in presubmits. Having separate tox environments for each would require running tox for each, increasing presubmit time and duplicating work (since most tests don't depend on aws or gcp). On Wed, Jan 15, 2020 at 1:54 PM Kyle Weaver

Re: [BEAM-9015] Adding pyXX-cloud instead of pyXX-gcp and pyXX-aws

2020-01-15 Thread Kyle Weaver
Just now seeing this -- are we sure we want to mix the signal from what are logically two totally separate test suites? Or from the opposite perspective, what's the motivation for wanting one test suite instead of two? On Tue, Jan 14, 2020 at 3:25 PM Pablo Estrada wrote: > now back from the holi

Re: [BEAM-9015] Adding pyXX-cloud instead of pyXX-gcp and pyXX-aws

2020-01-14 Thread Pablo Estrada
now back from the holidays, I intend to do this - one of these days. On Thu, Dec 26, 2019 at 12:51 PM Udi Meiri wrote: > +1 > > On Mon, Dec 23, 2019, 17:28 Robert Bradshaw wrote: > >> Makes sense to me. >> >> On Mon, Dec 23, 2019 at 3:33 PM Pablo Estrada wrote: >> > >> > Hi all, >> > a cou

Re: [BEAM-9015] Adding pyXX-cloud instead of pyXX-gcp and pyXX-aws

2019-12-26 Thread Udi Meiri
+1 On Mon, Dec 23, 2019, 17:28 Robert Bradshaw wrote: > Makes sense to me. > > On Mon, Dec 23, 2019 at 3:33 PM Pablo Estrada wrote: > > > > Hi all, > > a couple of contributors [1][2] have been kind enough to add support for > s3 filesystem[3] for the Python SDK. Part of this involved adding a

Re: [BEAM-9015] Adding pyXX-cloud instead of pyXX-gcp and pyXX-aws

2019-12-23 Thread Robert Bradshaw
Makes sense to me. On Mon, Dec 23, 2019 at 3:33 PM Pablo Estrada wrote: > > Hi all, > a couple of contributors [1][2] have been kind enough to add support for s3 > filesystem[3] for the Python SDK. Part of this involved adding a tox task > called py37-aws, to install the relevant dependencies a

[BEAM-9015] Adding pyXX-cloud instead of pyXX-gcp and pyXX-aws

2019-12-23 Thread Pablo Estrada
Hi all, a couple of contributors [1][2] have been kind enough to add support for s3 filesystem[3] for the Python SDK. Part of this involved adding a tox task called py37-aws, to install the relevant dependencies and run unit tests for it (in a mocked-out environment). To avoid running a full extra