Re: [DISCUSS] Remove TimerInternals.deleteTimer(*) and Timer.cancel()

2017-05-10 Thread Aljoscha Krettek
e not encountered such a strong case. >> best, JingsongLee >> >> -- >> From:Kenneth Knowles <k...@google.com.INVALID> >> Time:2017 May 9 (Tue) 05:45 >> To:dev <dev@beam.apache.org> >> Subject:Re: [DISCUSS] Remove TimerInternals.deleteTimer(*) and >> Timer.ca

Re: [DISCUSS] Remove TimerInternals.deleteTimer(*) and Timer.cancel()

2017-05-09 Thread Kenneth Knowles
gt; wrote: > +1 to remove this, I have not encountered such a strong case. > best, JingsongLee > > -- > From:Kenneth Knowles <k...@google.com.INVALID> > Time:2017 May 9 (Tue) 05:45 > To:dev <dev@b

Re: [DISCUSS] Remove TimerInternals.deleteTimer(*) and Timer.cancel()

2017-05-08 Thread JingsongLee
+1 to remove this, I have not encountered such a strong case. best, JingsongLee -- From:Kenneth Knowles <k...@google.com.INVALID> Time:2017 May 9 (Tue) 05:45 To:dev <dev@beam.apache.org> Subject:Re: [DIS

Re: [DISCUSS] Remove TimerInternals.deleteTimer(*) and Timer.cancel()

2017-05-08 Thread Kenneth Knowles
Interesting! I believe the only thing we need to change to remove it for FSR is https://github.com/apache/beam/blob/master/sdks/java/core /src/main/java/org/apache/beam/sdk/state/Timer.java#L60 Here is how I might summarize the possibilities, at the risk of having something quite wrong: -

[DISCUSS] Remove TimerInternals.deleteTimer(*) and Timer.cancel()

2017-05-08 Thread Aljoscha Krettek
I wanted to bring this up before the First Stable release and see what other people think. The methods I’m talking about are: void deleteTimer(StateNamespace namespace, String timerId, TimeDomain timeDomain); @Deprecated void deleteTimer(StateNamespace namespace, String timerId); @Deprecated