Re: [PROPOSAL] @OnWindowExpiration

2017-04-03 Thread Etienne Chauchot
+1 Etienne Le 28/03/2017 à 22:27, Kenneth Knowles a écrit : Hi all, I have a little extension to the stateful DoFn annotations to circulate for feedback: Allow a method to be annotated with @OnWindowExpiration to automatically get a callback at some point after the window has expired, but bef

Re: [PROPOSAL] @OnWindowExpiration

2017-03-30 Thread Jean-Baptiste Onofré
+1 Regards JB On 03/28/2017 10:27 PM, Kenneth Knowles wrote: Hi all, I have a little extension to the stateful DoFn annotations to circulate for feedback: Allow a method to be annotated with @OnWindowExpiration to automatically get a callback at some point after the window has expired, but bef

Re: [PROPOSAL] @OnWindowExpiration

2017-03-30 Thread Kenneth Knowles
> > > > > > > 1. Expire the window and start dropping any more input > > > > > 2. Fire the user's expiration callback > > > > > 3. Delete the state for the window > > > > > > > > > > This actually made me think of a sp

Re: [PROPOSAL] @OnWindowExpiration

2017-03-30 Thread Tyler Akidau
allback > > > > 3. Delete the state for the window > > > > > > > > This actually made me think of a special property of > @OnWindowExpiration: > > > > we can forbid Timer parameters. If we followed Robert's idea we > could do > > &

Re: [PROPOSAL] @OnWindowExpiration

2017-03-29 Thread Aljoscha Krettek
ation callback > > > 3. Delete the state for the window > > > > > > This actually made me think of a special property of @OnWindowExpiration: > > > we can forbid Timer parameters. If we followed Robert's idea we could do > > > static analysis and en

Re: [PROPOSAL] @OnWindowExpiration

2017-03-29 Thread Kenneth Knowles
al feature. It is more than > > convenience. > > > > Kenn > > > > > > > > > --From:Kenneth > > > Knowles Time:2017 Mar 29 (Wed) 09:07To:dev < > > > dev@beam.apache.org>Sub

Re: [PROPOSAL] @OnWindowExpiration

2017-03-29 Thread Thomas Groh
--------- > --From:Kenneth > > Knowles Time:2017 Mar 29 (Wed) 09:07To:dev < > > dev@beam.apache.org>Subject:Re: [PROPOSAL] @OnWindowExpiration > > On Tue, Mar 28, 2017 at 2:47 PM, Eugene Kirpichov < > > kirpic...@google.com.

Re: [PROPOSAL] @OnWindowExpiration

2017-03-29 Thread Kenneth Knowles
pecial feature. It is more than convenience. Kenn > --From:Kenneth > Knowles Time:2017 Mar 29 (Wed) 09:07To:dev < > dev@beam.apache.org>Subject:Re: [PROPOSAL] @OnWindowExpiration > On Tue, Mar 28, 2017 at 2:47 PM,

Re: [PROPOSAL] @OnWindowExpiration

2017-03-29 Thread JingsongLee
--From:Kenneth Knowles Time:2017 Mar 29 (Wed) 09:07To:dev Subject:Re: [PROPOSAL] @OnWindowExpiration On Tue, Mar 28, 2017 at 2:47 PM, Eugene Kirpichov < kirpic...@google.com.invalid> wrote: > Kenn, can you quote some use cases for this, to make it more c

Re: [PROPOSAL] @OnWindowExpiration

2017-03-28 Thread Kenneth Knowles
On Tue, Mar 28, 2017 at 2:47 PM, Eugene Kirpichov < kirpic...@google.com.invalid> wrote: > Kenn, can you quote some use cases for this, to make it more clear what are > the consequences of having this API in this form? > > I recall that one of the main use cases was batching DoFn, right? > I beli

Re: [PROPOSAL] @OnWindowExpiration

2017-03-28 Thread Eugene Kirpichov
Kenn, can you quote some use cases for this, to make it more clear what are the consequences of having this API in this form? I recall that one of the main use cases was batching DoFn, right? On Tue, Mar 28, 2017 at 1:37 PM Kenneth Knowles wrote: > On Tue, Mar 28, 2017 at 1:32 PM, Robert Bradsh

Re: [PROPOSAL] @OnWindowExpiration

2017-03-28 Thread Kenneth Knowles
On Tue, Mar 28, 2017 at 1:32 PM, Robert Bradshaw < rober...@google.com.invalid> wrote: > Another alternative is to be able to set special timers, e.g. end of window > and expiration of window. That at least addresses (2). > Potentially a tangent, but that would perhaps fit in with the idea of rem

Re: [PROPOSAL] @OnWindowExpiration

2017-03-28 Thread Robert Bradshaw
Another alternative is to be able to set special timers, e.g. end of window and expiration of window. That at least addresses (2). On Tue, Mar 28, 2017 at 1:27 PM, Kenneth Knowles wrote: > Hi all, > > I have a little extension to the stateful DoFn annotations to circulate for > feedback: Allow a

[PROPOSAL] @OnWindowExpiration

2017-03-28 Thread Kenneth Knowles
Hi all, I have a little extension to the stateful DoFn annotations to circulate for feedback: Allow a method to be annotated with @OnWindowExpiration to automatically get a callback at some point after the window has expired, but before the state for the window has been cleared. Today, a user can