Re: [PROPOSAL] Remove KeyedCombineFn

2017-04-22 Thread Pei HE
+1 On Sat, Apr 22, 2017 at 12:16 PM, Jean-Baptiste Onofré wrote: > +1 > > Regards > JB > > > On 04/21/2017 07:24 PM, Kenneth Knowles wrote: > >> Hi all, >> >> I propose that we remove KeyedCombineFn before the first stable release. >> >> I don't think it adds enough value for

Re: [PROPOSAL] Remove KeyedCombineFn

2017-04-21 Thread Jean-Baptiste Onofré
+1 Regards JB On 04/21/2017 07:24 PM, Kenneth Knowles wrote: Hi all, I propose that we remove KeyedCombineFn before the first stable release. I don't think it adds enough value for the complexity it adds to e.g. CombineWithContext [1] and state [2, 3], and it doesn't seem to me that users

Re: [PROPOSAL] Remove KeyedCombineFn

2017-04-21 Thread Aljoscha Krettek
+1, as I’m almost always in favour of simplification > On 21. Apr 2017, at 19:59, Robert Bradshaw > wrote: > > Strongly in favor of removing this. If it's actually needed one can > incorporate the key into the value for inspection in the various > phases of the

Re: [PROPOSAL] Remove KeyedCombineFn

2017-04-21 Thread Robert Bradshaw
Strongly in favor of removing this. If it's actually needed one can incorporate the key into the value for inspection in the various phases of the CombineFn, so it's no loss of expressiveness. It's perfectly reasonable to make this (rare) usecase more complicated to greatly simplify the common

Re: [PROPOSAL] Remove KeyedCombineFn

2017-04-21 Thread Sourabh Bajaj
+1 On Fri, Apr 21, 2017 at 10:53 AM Thomas Groh wrote: > A happy +1. This simplifies the code base, and if we find a compelling use, > it shouldn't be too bad to add it back in. > > On Fri, Apr 21, 2017 at 10:24 AM, Kenneth Knowles > wrote: >

Re: [PROPOSAL] Remove KeyedCombineFn

2017-04-21 Thread Thomas Groh
A happy +1. This simplifies the code base, and if we find a compelling use, it shouldn't be too bad to add it back in. On Fri, Apr 21, 2017 at 10:24 AM, Kenneth Knowles wrote: > Hi all, > > I propose that we remove KeyedCombineFn before the first stable release. > > I

Re: [PROPOSAL] Remove KeyedCombineFn

2017-04-21 Thread Davor Bonaci
+1 -- this is a good simplification. On Fri, Apr 21, 2017 at 10:24 AM, Kenneth Knowles wrote: > Hi all, > > I propose that we remove KeyedCombineFn before the first stable release. > > I don't think it adds enough value for the complexity it adds to e.g. >

[PROPOSAL] Remove KeyedCombineFn

2017-04-21 Thread Kenneth Knowles
Hi all, I propose that we remove KeyedCombineFn before the first stable release. I don't think it adds enough value for the complexity it adds to e.g. CombineWithContext [1] and state [2, 3], and it doesn't seem to me that users really use it when we might expect. I am happy to be demonstrated