Re: [VOTE] Release 2.43.0, release candidate #1

2022-11-11 Thread Anand Inguva via dev
Thanks Valentyn for catching this. There is a PR[1] in flight, almost ready to be merged with the fix. Thanks, Anand PR: https://github.com/apache/beam/pull/24114 On Thu, Nov 10, 2022 at 8:46 PM Chamikara Jayalath wrote: > Ack. Thanks for finding this. > > - Cham > > On Thu, Nov 10, 2022 at

Re: [VOTE] Release 2.43.0, release candidate #1

2022-11-10 Thread Chamikara Jayalath via dev
Ack. Thanks for finding this. - Cham On Thu, Nov 10, 2022 at 5:42 PM Valentyn Tymofieiev wrote: > -1. > It looks like the format of Python wheels has changed. > We should update the stager code and python container entrypoint code, > otherwise we will have a 2 min pipeline start time regression

Re: [VOTE] Release 2.43.0, release candidate #1

2022-11-10 Thread Valentyn Tymofieiev via dev
-1. It looks like the format of Python wheels has changed. We should update the stager code and python container entrypoint code, otherwise we will have a 2 min pipeline start time regression on some runners. Opened https://github.com/apache/beam/issues/24110 On Thu, Nov 10, 2022 at 11:10 AM Chami

Re: [VOTE] Release 2.43.0, release candidate #1

2022-11-10 Thread Chamikara Jayalath via dev
Thanks folks. Blocking issues were https://github.com/apache/beam/issues/24065 and https://github.com/apache/beam/pull/24041. I'll build RC2 when fixes are cherry-picked. This vote is now closed. - Cham On Thu, Nov 10, 2022 at 11:03 AM Anand Inguva wrote: > +1 (non-binding) validated Python

Re: [VOTE] Release 2.43.0, release candidate #1

2022-11-10 Thread Anand Inguva via dev
+1 (non-binding) validated Python SDK QuickStart, Beam RunInference examples on Direct and Dataflow Runner. Also, verified the Python 3.10 artifacts. On Wed, Nov 9, 2022 at 1:40 PM Chamikara Jayalath via dev < dev@beam.apache.org> wrote: > Ack. There's another potential cherry-pick here: > https

Re: [VOTE] Release 2.43.0, release candidate #1

2022-11-09 Thread Chamikara Jayalath via dev
Ack. There's another potential cherry-pick here: https://github.com/apache/beam/pull/24041 This should not prevent validation against RC1 for any other potential regressions. I'll build a RC2 when cherry-picks are in. Thanks, Cham On Wed, Nov 9, 2022 at 9:30 AM Ritesh Ghorse via dev wrote: >

Re: [VOTE] Release 2.43.0, release candidate #1

2022-11-09 Thread Ritesh Ghorse via dev
The Dataframe wrapper in Go SDK is failing because of https://github.com/apache/beam/issues/24065. I have a PR here to unblock the release. The current PR allows Dataframe wrapper to work as expected but proper fix should be added while merging RunInferen

Re: [VOTE] Release 2.43.0, release candidate #1

2022-11-09 Thread Alexey Romanenko
+1 (binding) Tested with https://github.com/Talend/beam-samples/ (Java SDK v8 & v11, Spark 3 runner). --- Alexey > On 9 Nov 2022, at 01:38, Chamikara Jayalath via dev > wrote: > > Hi everyone, > Please review and vote on the release candidate #1 fo

[VOTE] Release 2.43.0, release candidate #1

2022-11-08 Thread Chamikara Jayalath via dev
Hi everyone, Please review and vote on the release candidate #1 for the version 2.43.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) Reviewers are encouraged to test their own use cases with the release candidate, and vote +1 if no