Re: Constant for beam:runner:executable_stage:v1 ?

2023-12-20 Thread Robert Bradshaw via dev
Not at all. (We may want to lift it to a proto definition that can be shared for all languages, and similarly for "beam:runner:source:v1" and "beam:runner:sink:v1" but moving it to a common spot in Python at least is an improvement. On Wed, Dec 20, 2023 at 1:19 PM Joey Tran wrote: > Would it

Re: Constant for beam:runner:executable_stage:v1 ?

2023-12-20 Thread Joey Tran
Would it feel too wrong to put it in commo_urns? [1] [1] https://github.com/apache/beam/blob/8de029a412ab3e87ec92caf29818b51dab4ab02d/sdks/python/apache_beam/portability/common_urns.py On Wed, Dec 20, 2023 at 4:06 PM Robert Bradshaw via dev wrote: > Technically it's not really part of the

Re: Constant for beam:runner:executable_stage:v1 ?

2023-12-20 Thread Robert Bradshaw via dev
Technically it's not really part of the model so much as an implementation detail, but it likely does make sense to put somewhere common. On Wed, Dec 20, 2023 at 12:55 PM Joey Tran wrote: > Hey all, > > Is there a particular reason we hard code > "beam:runner:executable_stage:v1" everywhere in

Constant for beam:runner:executable_stage:v1 ?

2023-12-20 Thread Joey Tran
Hey all, Is there a particular reason we hard code "beam:runner:executable_stage:v1" everywhere in the python SDK instead of putting it in common_urns?