Re: Docker Run Options in SDK Container

2019-08-09 Thread Lukasz Cwik
On Fri, Aug 2, 2019 at 11:00 AM Chad Dombrova wrote: > Hi all, > I’m a bit confused about the desire to use json for the environment_config. > Note that complex PipelineOptions are already expected to be in JSON format[1, 2]. This has solved many string parsing and ambiguity issues. > It’s

Re: Docker Run Options in SDK Container

2019-08-02 Thread Chad Dombrova
Hi all, I’m a bit confused about the desire to use json for the environment_config. It’s harder to use json on the command line, such that now we’re talking about the value being *either* a docker image name *or* a path to a json file (OR maybe yaml too!), which is not only less convenient than

Re: Docker Run Options in SDK Container

2019-07-16 Thread Ankur Goenka
Thanks for summarizing the discussion. A few comments inline below: On Mon, Jul 15, 2019 at 5:28 PM Sam Bourne wrote: > Hello Beam devs, > > I’ve opened a PR (https://github.com/apache/beam/pull/8982) to support > passing options/flags to the docker run command executed as part of the >

Docker Run Options in SDK Container

2019-07-15 Thread Sam Bourne
Hello Beam devs, I’ve opened a PR (https://github.com/apache/beam/pull/8982) to support passing options/flags to the docker run command executed as part of the portable environment workflow. I’m in need of providing specific volumes and possibly other docker run options as I refine our custom