Hi Ankur On Fri, Mar 10, 2017 at 6:08 PM, Ankur Chauhan <an...@malloc64.com> wrote:
> Hi all, > > This is my first go at contributing some simple changes to the BigTableIO > in beam. The main intent was to update the dependency to 0.9.5.1 from the > current 0.9.2 which would address some changes to the classes provided by > the bigtable-client-core package. > > This addresses the following: > * [BEAM-812 <https://issues.apache.org/jira/browse/BEAM-812>] > https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/1056 > * As well as some TODOs: > https://github.com/apache/beam/blob/master/sdks/java/io/goog > le-cloud-platform/src/main/java/org/apache/beam/sdk/io/ > gcp/bigtable/BigtableIO.java#L214 > > My changes are at: > https://github.com/ankurcha/beam/commit/9630c7478f3566c65f65 > e84d6ca0674e618af12f > but > I am not sure what the correct protocol is for submitting a change like > this. > > 1. Should I open multiple pull requests for each ticket (even though the > changes are highly coupled) and add another jira ticket for the version > update of the client core? or, Should I just put all the ticket numbers in > a single pull request? > I think it is a good idea to at least separate dependency changes from the other changes for clean isolation. In general, the contribution guide also calls for smaller PRs [1] when possible. > > 2. Would this change be a part of 0.6.0 release (already in rc1) or would > it go out as a part of 0.7.0 release? > 0.6.0 is currently progressing in a branch, and we are only cherry picking essential things that are blocking the release. Other changes (including this one) would be part of the future releases. Thanks, Ahmet [1] https://beam.apache.org/contribute/contribution-guide/#create-a-pull-request > > Thanks! > > -- Ankur Chauhan >
