Re: Implementing tuple type support in for ClickHouse connector

2023-12-04 Thread Byron Ellis via dev
Indeed, hence me cheaping out and just tagging the base type with the one I want (in my case things like "UUID" which are just byte arrays). :-) In any case, the (very very very early) draft PR is here: https://github.com/apache/beam/pull/29569 On Mon, Dec 4, 2023 at 9:26 AM Robert Bradshaw via

Re: Implementing tuple type support in for ClickHouse connector

2023-12-04 Thread Robert Bradshaw via dev
Note that Logical types are not as portable (e.g. for cross-langauge use). On Mon, Dec 4, 2023 at 9:18 AM Alexey Romanenko wrote: > > Did you take a look by chance on > org.apache.beam.sdk.schemas.Schema.LogicalType? Can it be helpful for your > case? > > On 4 Dec 2023, at 12:02, Mark Zitnik

Re: Implementing tuple type support in for ClickHouse connector

2023-12-04 Thread Mark Zitnik
I was thinking to use LogicalType or Row need to figure out how LogicalType works, it looks like we can have nested row and it can be a good feet Byron Ellis can you attach a link to your branch for inspiration On Mon, Dec 4, 2023 at 7:18 PM Alexey Romanenko wrote: > Did you take a look

Re: Implementing tuple type support in for ClickHouse connector

2023-12-04 Thread Alexey Romanenko
Did you take a look by chance on org.apache.beam.sdk.schemas.Schema.LogicalType? Can it be helpful for your case? > On 4 Dec 2023, at 12:02, Mark Zitnik wrote: > > Yes I know it is done in org.apache.beam.sdk.io.clickhouse.TableSchema (Did > it for several other types), but since Tuple is a

Re: Implementing tuple type support in for ClickHouse connector

2023-12-04 Thread Byron Ellis via dev
I'm not all that familiar with Clickhouse, but from the docs it looks like Tuples are basically some sort of anonymous structure so I'm guessing you'll want to encode it as a Row itself... that's a lossy conversion though so probably some sort of Logical Type that wraps the Row object is the

Re: Implementing tuple type support in for ClickHouse connector

2023-12-04 Thread Mark Zitnik
Yes I know it is done in org.apache.beam.sdk.io.clickhouse.TableSchema (Did it for several other types), but since Tuple is a nested type that can hold any number of other ClickHouse types I was wondering what is the best type from the Apache Beam side in order to implement it. Mark On Mon, Dec

Re: Implementing tuple type support in for ClickHouse connector

2023-12-04 Thread Alexey Romanenko
Hi Mark, What do you mean by “support” in this case? To map this ClickHouse data type to a Beam Schema data type as it’s done in org.apache.beam.sdk.io.clickhouse.TableSchema for other types or something else? — Alexey > On 3 Dec 2023, at 10:35, Mark Zitnik wrote: > > Hi Team, > > I am one

Implementing tuple type support in for ClickHouse connector

2023-12-03 Thread Mark Zitnik
Hi Team, I am one of the committers of the ClickHouse integration team. I need to add support for Tuple in the ClickHouse connector for Apache Beam. What is the best approval for implementing that? Tuple( https://clickhouse.com/docs/en/sql-reference/data-types/tuple) in a nested data