Re: JUnit 5 TestPipeline

Decided to go with https://github.com/apache/beam/pull/4360 to start. It still relies on hamcrest - which should be dropped at some point for JUnit 5 - but it is not a blocker to use JUnit 5 and the asserts can be done with assertTrue(BooleanSupplier) or any other JUnit 5 utility. Romain Manni-Bu

Re: JUnit 5 TestPipeline

PAssert & TestPipeline are the first targets for sure. We have some extend of TestPipeline (for instance in the Spark runner for streaming part). But it should be transparent. Regards JB On 01/06/2018 09:09 AM, Romain Manni-Bucau wrote: PAssert is the next one I'd like to tackle once i managed

Re: JUnit 5 TestPipeline

PAssert is the next one I'd like to tackle once i managed to run the test (need to fix the runner setup in my branch). Otherwise logic seems extractable not too badly so I'm very optimistic. If you have some utilities you want I have a look just dump it here, I will try to check beginning of next

Re: JUnit 5 TestPipeline

That sounds interesting. Will there be compatibility challenges with how much changed between JUnit 4 and 5 since I believe we have a lot of testing utilities in our test jars which some users do rely on. On Fri, Jan 5, 2018 at 9:08 AM, Romain Manni-Bucau wrote: > FYI, started to code a bit in h

Re: JUnit 5 TestPipeline

FYI, started to code a bit in https://github.com/rmannibucau/incubator-beam/tree/fb/BEAM-3415_junit-5-integration The surefire setup is not yet correct but it gives some idea of where it goes if you want to have a look. Will try to finish it next week Have a good week-end! Romain Manni-Bucau @

Re: JUnit 5 TestPipeline

It sounds good, thanks. Let me add as reviewer on the PR. Thanks ! Regards JB On 01/05/2018 03:41 PM, Romain Manni-Bucau wrote: created https://issues.apache.org/jira/browse/BEAM-3415 for reference Romain Manni-Bucau @rmannibucau | Blog

Re: JUnit 5 TestPipeline

created https://issues.apache.org/jira/browse/BEAM-3415 for reference Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn

Re: JUnit 5 TestPipeline

Hi, not yet planned. But interesting for sure. Regards JB On 01/05/2018 10:45 AM, Romain Manni-Bucau wrote: Hi guys, Any plan to work on a JUnit 5 test pipeline? I can surely give some help if needed but would be nice to support it soon. Romain Manni-Bucau @rmannibucau

JUnit 5 TestPipeline

Hi guys, Any plan to work on a JUnit 5 test pipeline? I can surely give some help if needed but would be nice to support it soon. Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github <