Re: PCollectionViews$SimplePCollectionView.hashCode allocates memory

2018-10-31 Thread Vojtech Janota
Ok, will do both. Thanks, Vojta On Wed, Oct 31, 2018 at 2:32 PM Ismaël Mejía wrote: > Vojta you are right, your implementation seems like a good improvement. > Can you please create a JIRA and eventually if you are interested do a > PR to contribute a fix for it. > > Regards, > Ismaël > On Wed,

Re: PCollectionViews$SimplePCollectionView.hashCode allocates memory

2018-10-31 Thread Ismaël Mejía
Vojta you are right, your implementation seems like a good improvement. Can you please create a JIRA and eventually if you are interested do a PR to contribute a fix for it. Regards, Ismaël On Wed, Oct 31, 2018 at 2:18 PM Vojtech Janota wrote: > > Hi, > > I'm currently profiling memory consumptio

PCollectionViews$SimplePCollectionView.hashCode allocates memory

2018-10-31 Thread Vojtech Janota
Hi, I'm currently profiling memory consumption of our Beam pipeline and have noticed that org.apache.beam.sdk.values.PCollectionViews$SimplePCollectionView.hashCode() makes noticeable heap allocations. The implementation is: return Objects.hash(tag); That itself translates to: return Arrays.