Re: Problems with E2E test

2021-01-20 Thread Brian Hulette
Sorry this was my mistake when I reviewed the PR last week. I suggested renaming this new E2E test to *IT since it looks like an integration test. This means that the test will run as part of the "Java Examples Dataflow" PreCommit. However the test is also using a local fake of PubSub, which won't

Re: Problems with E2E test

2021-01-18 Thread Boyuan Zhang
It does seem like the Dataflow will do some validation around PubSub params before actually creating the pipeline. That's fair for Dataflow because Dataflow will swap the PubSubIO from beam implementation into Dataflow native one. I think if you really want to run your virtual PubSub with Dataflow

Problems with E2E test

2021-01-18 Thread Ramazan Yapparov
Hi Beam! We've been writing E2E test for KafkaToPubsub example pipeline. Instead of depending on some real Cloud Pubsub and Kafka instances we decided to use Testcontainers. We launch Kafka and PubSub Emulator containers and after that we pass containers urls into pipeline options and run the pip