Re: Quota issues again

2019-10-29 Thread Kenneth Knowles
Post-commit runs all precommits. The builder for the Jenkins jobs creates separate jobs with suffixes: * _Commit (for when a commit is pushed to a PR) * _Phrase (for when someone asks to run it) * _Cron (run as a post-commit against master) This way, the different jobs have independent

Re: Quota issues again

2019-10-29 Thread Mikhail Gryzykhin
IIRC currently, post-commit doesn't run pre-commits. However we have precommit_cron jobs that run pre-commits periodically. However it sums up to dozens of jobs that is really hard to monitor. If we split things even further, we definitely need to combine result into something more easily

Re: Quota issues again

2019-10-29 Thread Chad Dombrova
> +1 for splitting pre-commit tests into smaller modules. However in this > case we need to run all the small tests periodically and have some combined > flag or dashboard for regular monitoring. Otherwise we might not run/check > on big amount of tests. > post-commit seems like the best place

Re: Quota issues again

2019-10-29 Thread Mikhail Gryzykhin
+1 for splitting pre-commit tests into smaller modules. However in this case we need to run all the small tests periodically and have some combined flag or dashboard for regular monitoring. Otherwise we might not run/check on big amount of tests. On Mon, Oct 28, 2019 at 6:39 PM Kenneth Knowles

Re: Quota issues again

2019-10-28 Thread Kenneth Knowles
It may also be advantageous to separate most submodules to not run a giant generic Java precommit. Each IO really only needs its own, and to register itself in the global Java precommit run only for the core. The bookkeeping may become quite a lot, but this is the natural structure. Kenn On Mon,

Re: Quota issues again

2019-10-28 Thread Chad Dombrova
Can we get more aggressive about separating tests into groups by those that are dependent on other languages and those that are not? I think we could dramatically reduce our backlog if we didn’t run all of the Java tests every time a commit is made that only affects python code, and vice versa.

Re: Quota issues again

2019-10-28 Thread Mikhail Gryzykhin
Quota jira issue: https://issues.apache.org/jira/browse/BEAM-8195 On Mon, Oct 28, 2019 at 2:05 PM Mikhail Gryzykhin wrote: > Hi everyone, > > > While validating release branch, I got failure due Quota again. Also, current > queue time for jobs is more than 1.5 hours. > > > I'm not sure if it

Quota issues again

2019-10-28 Thread Mikhail Gryzykhin
Hi everyone, While validating release branch, I got failure due Quota again. Also, current queue time for jobs is more than 1.5 hours. I'm not sure if it is worth starting another thread on tests efficiency, but still want to keep this mail to highlight the issues. See PS for links.