Re: RabbitMqIO issues and open PRs

2019-10-31 Thread Jean-Baptiste Onofré
Hi, I just provided feedback in the PRs. Let me know if you want to chat about some initial implementation (as I'm the original author of the IO, I remember some discussion in the past ;) ). Regards JB On 31/10/2019 21:38, Daniel Robert wrote: > I'm pretty new to the Beam ecosystem, so apologie

Re: RabbitMqIO issues and open PRs

2019-10-31 Thread Jean-Baptiste Onofré
Hi Daniel, I will review and work on this IO. Sorry for the delay, I wasn't super active on Beam recently, but now back ;) Regards JB On 31/10/2019 21:38, Daniel Robert wrote: > I'm pretty new to the Beam ecosystem, so apologies if this is not the > right forum for this. > > My team has been l

Re: RabbitMqIO issues and open PRs

2019-10-31 Thread Eugene Kirpichov
Regarding review latency, FWIW I'm not super active on Beam these days but I'll be happy to review 1-2 PRs for RabbitMqIO (I'm @jkff). On Thu, Oct 31, 2019 at 8:47 PM Kenneth Knowles wrote: > Yes, thanks for emailing! We very much value sharing your intentions with > the community. For small cha

Re: RabbitMqIO issues and open PRs

2019-10-31 Thread Kenneth Knowles
Yes, thanks for emailing! We very much value sharing your intentions with the community. For small changes or fixes, you can just open a PR. For larger changes that could use feedback from the community (versus just the code reviewer) this list is the right place to go. If it is truly complex, a sh

Re: RabbitMqIO issues and open PRs

2019-10-31 Thread Reuven Lax
I think we would be happy to see improvements and contributions to .this component. Emailing this list is definitely the right first step - it gives anyone with knowledge of the RabbitMqIO component a chance to weigh in. You don't necessarily have to talk to component authors before submitting a PR

RabbitMqIO issues and open PRs

2019-10-31 Thread Daniel Robert
I'm pretty new to the Beam ecosystem, so apologies if this is not the right forum for this. My team has been learning and starting to use Beam for the past few months and have run into myriad problems with the RabbitIO connector for java, aspects of which seem perhaps fundamentally broken or i