Re: [DISCUSS] Guidelines for merging new runners and SDKs into master

I would add that we should really be looking for test suites and test utilities when a new runner/SDK is merged. The tests really drive the majority of our validation and really help reduce maintenance burden. I'm thinking of the suite of ValidatesRunner tests that live within the Java and Python

Re: [DISCUSS] Guidelines for merging new runners and SDKs into master

On Wed, Dec 20, 2017 at 6:45 PM, Henning Rohde wrote: >> > (3) Similarly to new runners, new SDKs should handle at least a useful >> > subset of the model, but not necessarily the whole model (at the time of >> > merge). A global-window-batch-only SDK targeting the portability

Re: [DISCUSS] Guidelines for merging new runners and SDKs into master

Thanks for the comments! > > (2) What are the minimal set of IO connectors a new SDK must support? > Given > > the upcoming cross-language feature in the portability framework, can we > > rely on that to meet the requirement > > without implementing any native IO connectors? > > It could be

Re: [DISCUSS] Guidelines for merging new runners and SDKs into master

On Tue, Dec 19, 2017 at 4:18 PM, Henning Rohde wrote: > Hi everyone, > > As part of the Go SDK development, I was looking at the guidelines for > merging new runners and SDKs into master [1] and I think they would benefit > from being updated to reflect the emerging