+1 (binding)
Verified signatures
Verified that there are no conscrypt classes or binaries in jar
Verified pom.xml has runtime dependency on conscrypt
On Thu, Mar 5, 2020 at 9:14 PM Jean-Baptiste Onofre wrote:
>
> +1 (binding)
>
> Regards
> JB
>
> Le 5 mars 2020 à 19:55, Luke Cwik a écrit :
>
>
+1 (binding)
Regards
JB
> Le 5 mars 2020 à 19:55, Luke Cwik a écrit :
>
> Please review the release of the following artifacts that we vendor:
> * beam-vendor-grpc-1_26_0
>
> Hi everyone,
> Please review and vote on the release candidate #1 for the version 0.3, as
> follows:
> [ ] +1,
+1 (binding)
Verified that conscrypt jars and .so files don't appear in the jar.
On Thu, Mar 5, 2020 at 10:55 AM Luke Cwik wrote:
> Please review the release of the following artifacts that we vendor:
> * beam-vendor-grpc-1_26_0
>
> Hi everyone,
> Please review and vote on the release
Cancelling this release, I made a mistake for the commit id which I built
from which I should have caught before sending this out.
On Thu, Mar 5, 2020 at 10:45 AM Luke Cwik wrote:
> Please review the release of the following artifacts that we vendor:
> * beam-vendor-grpc-1_26_0
>
> Hi
Looks like the vote is cancelled.
On Tue, Mar 3, 2020 at 2:03 PM Ismaël Mejía wrote:
> -1
>
> It seems we still are adding the conscrypt native libraries as part in
> META-INF
>
> $ jar tvf beam-vendor-grpc-1_26_0-0.3.jar | grep conscrypt
> 2218176 Mon Sep 17 10:36:24 CEST 2018
>
-1
It seems we still are adding the conscrypt native libraries as part in META-INF
$ jar tvf beam-vendor-grpc-1_26_0-0.3.jar | grep conscrypt
2218176 Mon Sep 17 10:36:24 CEST 2018
META-INF/native/libconscrypt_openjdk_jni-linux-x86_64.so
1720832 Mon Sep 17 10:36:24 CEST 2018
+1 (binding)
verified hashes
On Tue, Mar 3, 2020 at 11:20 AM Luke Cwik wrote:
> +1 (binding)
> Verified signatures
> Verified that there are no conscrypt classes in jar
> Verified pom.xml has runtime dependency on conscrypt
>
> On Tue, Mar 3, 2020 at 10:35 AM Jean-Baptiste Onofré
> wrote:
>
>>
+1 (binding)
Verified signatures
Verified that there are no conscrypt classes in jar
Verified pom.xml has runtime dependency on conscrypt
On Tue, Mar 3, 2020 at 10:35 AM Jean-Baptiste Onofré
wrote:
> +1 (binding)
>
> Regards
> JB
>
> Le mar. 3 mars 2020 ? 19:31, Luke Cwik a ?crit :
>
>> Please
+1 (binding)RegardsJBLe mar. 3 mars 2020 ? 19:31, Luke Cwik a ?crit :Please review the release of the following artifacts that we vendor: * beam-vendor-grpc-1_26_0Hi everyone,Please review and vote on the release candidate #1 for the version 0.3, as follows:[ ] +1, Approve the release[ ] -1, Do
