Re: Beam contribution

2019-04-08 Thread Michael Luckey
opened PR https://github.com/apache/beam/pull/8245 On Fri, Apr 5, 2019 at 10:53 PM Lukasz Cwik wrote: > Filed https://issues.apache.org/jira/browse/BEAM-7016 with the details. > > On Fri, Apr 5, 2019 at 1:47 PM Lukasz Cwik wrote: > >> Yes, it seems like the reset() method resets System.out even

Re: Beam contribution

2019-04-05 Thread Lukasz Cwik
Filed https://issues.apache.org/jira/browse/BEAM-7016 with the details. On Fri, Apr 5, 2019 at 1:47 PM Lukasz Cwik wrote: > Yes, it seems like the reset() method resets System.out even if it never > was initialized. Seems like a simple fix to have reset() be safe to call at > all times. Csaba or

Re: Beam contribution

2019-04-05 Thread Lukasz Cwik
Yes, it seems like the reset() method resets System.out even if it never was initialized. Seems like a simple fix to have reset() be safe to call at all times. Csaba or Michael, would either of you like to open a PR and send it my way? On Fri, Apr 5, 2019 at 1:39 PM Michael Luckey wrote: > Ah...

Re: Beam contribution

2019-04-05 Thread Michael Luckey
Ah... Did not yet debug. But wouldn't [1] mean setting system.out to 'null' on first call to @setup ? As there was no previous call to DataflowWorkerLoggingInitializer.initialize? https://github.com/apache/beam/blame/master/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/

Re: Beam contribution

2019-04-05 Thread Lukasz Cwik
We replace System.out/err to capture user logs and forward the logs for the Dataflow worker[1]. It could be that this test[2] is not resetting it afterwards which leaves it at null and then some future code causes it to fail. 1: https://github.com/apache/beam/blob/e69d69d72dc5b9c3d6069c0b71825c3c2

Re: Beam contribution

2019-04-05 Thread Michael Luckey
FWIW, the TimerRecieverTest is also failing consistently on my macOS. Running on my ubuntu VM, they pass. Now the stacktrace indicates an NullPinterException thrown out of the finally block [1] As this is really bad and of course would hide the cause, I added some diff --git a/sdks/java/harness/

Re: Beam contribution

2019-04-04 Thread Lukasz Cwik
I looked at the failures you were experiencing and the error message doesn't provide enough information to figure out why it is failing. On Wed, Apr 3, 2019 at 9:23 PM Csaba Kassai wrote: > Oh, I just missed it then :) > Thank you Lukasz for connecting us. > > Yeah, the two TimerReceiverTest tes

Re: Beam contribution

2019-04-03 Thread Csaba Kassai
Oh, I just missed it then :) Thank you Lukasz for connecting us. Yeah, the two TimerReceiverTest tests fail reliably for me. On Tue, 2 Apr 2019 at 23:53, Lukasz Cwik wrote: > +Ahmed > > I have added you as a contributor. > > It seems as though Ahmed had just picked up BEAM-3489 yesterday. R

Re: Beam contribution

2019-04-02 Thread Lukasz Cwik
+Ahmed I have added you as a contributor. It seems as though Ahmed had just picked up BEAM-3489 yesterday. Reach out to Ahmed if you would like to help them out with the task. Was TimerReceiverTest failing reliably when performing a parallel build or is it flaky? I have asked Chamikara to take

Re: Beam Contribution

2019-01-18 Thread Kenneth Knowles
Done & welcome! On Fri, Jan 18, 2019 at 1:53 PM Daniel Chen wrote: > Hello, > > I'm Daniel Chen from the Samza team at Linkedin. For my upcoming work on > the Beam Samza runner, I would like to be added as a contributor in order > to facilitate ticket tracking. My ASF jira username is dchen. > >

Re: Beam Contribution

2019-01-07 Thread Robert Burke
I like that idea. Even something as simple as "I'm working on X,Y,Z and here's my github profile." It would also be handy for allowing users tagging in specific folks if there's a particular aspect they want to discuss. On Mon, Jan 7, 2019, 7:01 AM Maximilian Michels wrote: > Hi David, > > Welco

Re: Beam Contribution

2019-01-07 Thread Maximilian Michels
Hi David, Welcome! I see you're already added by now. Thanks for introducing yourself. I'm Max, working on the Flink Runner. I wonder if it made sense to have an intro Wiki page with a little bit of information on committers and contributors? I think that would make it easier to get into the

Re: Beam Contribution

2018-12-19 Thread Kenneth Knowles
Hi Theo, and welcome! I have added you to the "Contributors" role on Beam Jira, so you should be able to assign tickets to yourself if you want. Kenn On Wed, Dec 19, 2018 at 12:00 PM Theodore Siu wrote: > To whom it may concern, > > My name is Theodore Siu. I am a customer facing data engineer