Re: Reviewers for SparkRunner

2020-09-22 Thread Alexey Romanenko
Thanks, I’ll take a look on this asap. Agree with Kyle’s approach with git history or just ask on dev@ after several days if nobody picked up your review (as you did). > On 21 Sep 2020, at 23:05, Kyle Weaver wrote: > > I think Alexey would be a good reviewer for this. > > Not sure about this

Reviewers for SparkRunner

2020-09-21 Thread tclemons
About a week ago I submitted the following pull request: https://github.com/apache/beam/pull/12850 I listed @jbonofre as a reviewer as they were listed in the OWNER file for the Spark runners.  However, I've yet to hear any response.  Is there someone else I should add as a reviewer? Appreciat

Re: Reviewers for SparkRunner

2020-09-21 Thread Kyle Weaver
I think Alexey would be a good reviewer for this. Not sure about this particular case, but in general Beam's OWNERS files are pretty outdated. If I'm not sure who to ask for a review, usually I look at the git history of a file to see who has actively changed it recently. On Mon, Sep 21, 2020 at