Re: Should you always have a separate PTransform class for a new transform?

2017-04-20 Thread Eugene Kirpichov
The discussion has been reignited on https://github.com/apache/beam/pull/2603 . I can see the pretty strong argument for not replicating all the features of Combine on the hypothetical helper transform like Count.Globally. I guess, then, I like Robert's option of having an interface like

Re: Should you always have a separate PTransform class for a new transform?

2017-02-07 Thread Dan Halperin
A little bit more inline: On Tue, Feb 7, 2017 at 5:15 PM, Eugene Kirpichov < kirpic...@google.com.invalid> wrote: > Hello, > > I was auditing Beam for violations of PTransform style guide > https://beam.apache.org/contribute/ptransform-style-guide/ and came across > another style point that

Re: Should you always have a separate PTransform class for a new transform?

2017-02-07 Thread Dan Halperin
I'll agree with the "Cons" by referencing back to this thread: https://lists.apache.org/thread.html/caa8k_flvcmx+tyksxdmcxxe9y_zyohe4ovht9f2jb1wckob...@mail.gmail.com On Tue, Feb 7, 2017 at 5:15 PM, Eugene Kirpichov < kirpic...@google.com.invalid> wrote: > Hello, > > I was auditing Beam for