Re: Splittable DoFn for Python SDK

2017-03-14 Thread Chamikara Jayalath
Thanks for the comments. I think we have enough agreement here to move detailed discussions to JIRA and PRs. I'll update this thread about the progress. I'll be happy to address any further comments/concerns in this thread or in the design doc as well. Thanks, Cham On Tue, Mar 14, 2017 at 1:21

Re: Splittable DoFn for Python SDK

2017-03-14 Thread Eugene Kirpichov
Thanks Cham! Agreed that this is a clean way to add SDF API to Python. And agreed that it's a good idea to follow as similar path to Java - direct runner first. The next easiest thing is going to be the various streaming runners. Please keep me cc'd on various PRs related to this. On Tue, Mar 14,

Re: Splittable DoFn for Python SDK

2017-03-14 Thread Robert Bradshaw
+1, I think this is a natural extension of the SDF to Python. On Tue, Mar 14, 2017 at 1:19 PM, Chamikara Jayalath wrote: > Thanks Eugene. Will keep you cc'd. > > - Cham > > On Tue, Mar 14, 2017 at 1:15 PM Eugene Kirpichov > wrote: > >> Thanks Cham! Agreed that this is a clean way to add SDF API

Re: Splittable DoFn for Python SDK

2017-03-14 Thread Chamikara Jayalath
Thanks Eugene. Will keep you cc'd. - Cham On Tue, Mar 14, 2017 at 1:15 PM Eugene Kirpichov wrote: > Thanks Cham! Agreed that this is a clean way to add SDF API to Python. > And agreed that it's a good idea to follow as similar path to Java - > direct runner first. The next easiest thing is goin

Re: Splittable DoFn for Python SDK

2017-03-14 Thread Chamikara Jayalath
Ccing Eugene and other authors of the original Splittable Dofn proposal. Thanks, Cham On Mon, Mar 6, 2017 at 10:32 AM Chamikara Jayalath wrote: > Thanks Ahmet. I created https://issues.apache.org/jira/browse/BEAM-1630 for > this. > > Any further comments are welcome :). > > Implementation wise,

Re: Splittable DoFn for Python SDK

2017-03-06 Thread Chamikara Jayalath
Thanks Ahmet. I created https://issues.apache.org/jira/browse/BEAM-1630 for this. Any further comments are welcome :). Implementation wise, I think we should add Splittable DoFn to streaming direct runner first, after [1] is finalized, and then follow it up with support for bounded sources and ot

Re: Splittable DoFn for Python SDK

2017-03-03 Thread Ahmet Altay
+1 Thank you, this is a great and clean API proposal. Ahmet On Fri, Mar 3, 2017 at 5:16 PM, Chamikara Jayalath wrote: > Hi All, > > I've put together a document that proposes a Splittable DoFn API for Python > SDK. > > https://docs.google.com/document/d/1h_zprJrOilivK2xfvl4L42vaX4DMYGfH > 1YDmi

Splittable DoFn for Python SDK

2017-03-03 Thread Chamikara Jayalath
Hi All, I've put together a document that proposes a Splittable DoFn API for Python SDK. https://docs.google.com/document/d/1h_zprJrOilivK2xfvl4L42vaX4DMYGfH1YDmi-s_ozM/edit?usp=sharing Splittable DoFn framework [1] is currently being implemented for Java SDK [2] and will unlock many use-cases t