Re: Stop using Perfkit Benchmarker tool in all tests?

2019-07-18 Thread Łukasz Gajowy
Thank you all for your comments. I started working on this. Here's the issue I created: https://issues.apache.org/jira/browse/BEAM-7772 For #2 (Python performance tests), there are no special setup for them. The only missing part I can see is metrics collection and data upload to a shared storage

Re: Stop using Perfkit Benchmarker tool in all tests?

2019-07-08 Thread Udi Meiri
The Python 3 incompatibility is reason enough to move off of Perfkit. (+1) On Mon, Jul 8, 2019 at 9:49 AM Mark Liu wrote: > Thanks for summarizing this discussion and post in dev list. I was closely > working on Python performance tests and those Perfkit problems are really > painful. So +1 to r

Re: Stop using Perfkit Benchmarker tool in all tests?

2019-07-08 Thread Mark Liu
Thanks for summarizing this discussion and post in dev list. I was closely working on Python performance tests and those Perfkit problems are really painful. So +1 to remove Perfkit and also remove those tests that are no longer maintained. For #2 (Python performance tests), there are no special s

Re: Stop using Perfkit Benchmarker tool in all tests?

2019-07-03 Thread Lukasz Cwik
Makes sense to me to move forward with your suggestion. On Wed, Jul 3, 2019 at 3:57 AM Łukasz Gajowy wrote: > Are there features in Perfkit that we would like to be using that we >> aren't? >> > > Besides the Kubernetes related code I mentioned above (that, I believe, > can be easily replaced) I

Re: Stop using Perfkit Benchmarker tool in all tests?

2019-07-03 Thread Łukasz Gajowy
> > Are there features in Perfkit that we would like to be using that we > aren't? > Besides the Kubernetes related code I mentioned above (that, I believe, can be easily replaced) I don't see any added value in having Perfkit. The Kubernetes parts could be replaced with a set of fine-grained Grad

Re: Stop using Perfkit Benchmarker tool in all tests?

2019-07-03 Thread Ismaël Mejía
+1 to remove Perfkit if we can cover what we need without it. One less tool to 'learn/understand/maintain' is always good. On Fri, Jun 28, 2019 at 5:31 PM Lukasz Cwik wrote: > > +1 for removing tests that are not maintained. > > Are there features in Perfkit that we would like to be using that we

Re: Stop using Perfkit Benchmarker tool in all tests?

2019-06-28 Thread Lukasz Cwik
+1 for removing tests that are not maintained. Are there features in Perfkit that we would like to be using that we aren't? Can we make the integration with Perfkit less brittle? If we aren't getting much and don't plan to get much value in the short term, removal makes sense to me. On Thu, Jun

Stop using Perfkit Benchmarker tool in all tests?

2019-06-27 Thread Łukasz Gajowy
Hi all, moving the discussion to the dev list: https://github.com/apache/beam/pull/8919. I think that Perfkit Benchmarker should be removed from all our tests. Problems that we face currently: 1. Changes to Gradle tasks/build configuration in the Beam codebase have to be reflected in Perfk