Re: Update confluent dependencies version in kafka io

2024-03-19 Thread Maciej Szwaja via dev
Great! Thanks for your help as well! Happy that my change made it through to the master. On Mon, Mar 18, 2024 at 7:34 PM Yi Hu wrote: > +1 to move forward with avro. Users can still stick with old avro version > if chosen to do so, and we have Avro compatibility tests also passed in >

Re: Update confluent dependencies version in kafka io

2024-03-18 Thread Yi Hu via dev
+1 to move forward with avro. Users can still stick with old avro version if chosen to do so, and we have Avro compatibility tests also passed in https://github.com/apache/beam/pull/30638 Thanks for doing this! On Fri, Mar 15, 2024 at 3:30 PM Maciej Szwaja via dev wrote: > Hi team, thanks for

Re: Update confluent dependencies version in kafka io

2024-03-15 Thread Maciej Szwaja via dev
Hi team, thanks for the answers and an update from me - I've created the PR https://github.com/apache/beam/pull/30638 which seems to pass the tests (sometimes they're flaky though, so I didn't manage to get all green in the checks yet), and also I was able to run a pipeline that reads avro records

Re: Update confluent dependencies version in kafka io

2024-03-11 Thread Valentyn Tymofieiev via dev
Welcome to dev@ Maciej. I think as long as an upgrade doesn't cause breaking changes for the users, there shouldn't be any concerns. Having a dependency on a 5 yr old library on the other hand is a concern. For Python SDK, we try to upgrade to new major versions within a year after they are

Re: Update confluent dependencies version in kafka io

2024-03-11 Thread XQ Hu via dev
This sounds great! Feel free to create an issue to track this work! On Mon, Mar 11, 2024 at 9:36 AM Maciej Szwaja via dev wrote: > Hi, > > This is my first email to this list, hello everyone! > > I have a question regarding the confluent version dependency that beam, or > more specifically

Update confluent dependencies version in kafka io

2024-03-11 Thread Maciej Szwaja via dev
Hi, This is my first email to this list, hello everyone! I have a question regarding the confluent version dependency that beam, or more specifically kafka io extension, is currently using. Tl;dr is that I'd like to update the confluent library version to something more recent, and was wondering