Thanks for doing so much work verifying this and analyzing it! It really
seems like we did all this for mockito, so it has very little risk of
impacting users. And you've verified it is working with mockito now. So I
think I'm in favor of unvendoring. This will make it much easier to get
bugfixes,
Hmm. Too bad the information on the jira is inadequate to explain or
justify the change. TBH if faced with a conflict between bytebuddy and
mockito, working to use mocks less, or in more straightforward ways, would
have been my preference. This isn't actually a diamond dep problem that
impacts
+1
Probably worth to check if we have dependencies that rely on Byte
Buddy that can produce conflicts but I doubt it.
My only worry was ASM leaking into the classpath, but it seems that
Byte Buddy already shades ASM so that should not be an issue.
Ismaël
On Thu, Mar 17, 2022 at 5:09 PM Liam
