Re: why Source#validate() is not declared to throw any exception

Looks like JIRA notification is temporarily not working. I have logged BEAM-1773 FYI On Mon, Mar 20, 2017 at 11:26 PM, Eugene Kirpichov < kirpic...@google.com.invalid> wrote: > I think it would make sense to allow the validate method to throw > Exception. > > On Mon, Mar 20, 2017, 11:21 PM

Re: why Source#validate() is not declared to throw any exception

Got it. Regarding Jira notification, we changed the notification schema to use comm...@beam.apache.org (it was using comm...@beam.incubator.apache.org), but I don't think it's related, I think it's a Jira service/mail issue (even if status.apache.org doesn't show anything). I gonna ping Infra

Re: why Source#validate() is not declared to throw any exception

I just discussed with Daniel (from Infra), we've had a global networking issue affecting mail and LDAP. That's why the Jira notifications are in the queue for now. Regards JB On 03/21/2017 03:13 PM, Ted Yu wrote: Looks like JIRA notification is temporarily not working. I have logged

Re: why Source#validate() is not declared to throw any exception

I think it would make sense to allow the validate method to throw Exception. On Mon, Mar 20, 2017, 11:21 PM Jean-Baptiste Onofré wrote: > Hi Ted, > > validate() is supposed to throw runtime exception (IllegalStateException, > RuntimeException, ...) to "traverse" the executor.

Re: why Source#validate() is not declared to throw any exception

Hi Ted, validate() is supposed to throw runtime exception (IllegalStateException, RuntimeException, ...) to "traverse" the executor. Regards JB On 03/21/2017 01:56 AM, Ted Yu wrote: Hi, I was reading HDFSFileSource.java where: @Override public void validate() { ... } catch

why Source#validate() is not declared to throw any exception

Hi, I was reading HDFSFileSource.java where: @Override public void validate() { ... } catch (IOException | InterruptedException e) { throw new RuntimeException(e); } Why is validate() not declared to throw any exception ? If validation doesn't pass, there is nothing to