Re: FnAPI proto backwards compatibility

2020-02-11 Thread Kenneth Knowles
On Tue, Feb 11, 2020 at 8:38 AM Robert Bradshaw wrote: > On Mon, Feb 10, 2020 at 7:35 PM Kenneth Knowles wrote: > > > > On the runner requirements side: if you have such a list at the pipeline > level, it is an opportunity for the list to be inconsistent with the > contents of the pipeline. For

Re: Sphinx Docs Command Error (:sdks:python:test-suites:tox:pycommon:docs)

2020-02-11 Thread jincheng sun
I think it's a good advice to remove the "-j 8" option if it doesn't affect the performance much. Udi Meiri 于2020年2月12日周三 上午2:20写道: > For me the difference was about 20s longer (40s -> 60s approx). Not > significant IMO > > On Tue, Feb 11, 2020 at 9:59 AM Ahmet Altay wrote: > >> Should we

[PROPOSAL] Preparing for Beam 2.20.0 release

2020-02-11 Thread Rui Wang
Hi all, The next (2.20.0) release branch cut is scheduled for 02/26, according to the calendar . I would like to volunteer myself to do this release. The plan is to cut the branch on that date,

Re: Jenkins Jobs Trigger Request

2020-02-11 Thread Shoaib Zafar
Thanks Ismaël. *Shoaib Zafar* Software Engineering Lead Mobile: +92 333 274 6242 Skype: live:shoaibzafar_1 On Tue, Feb 11, 2020 at 3:25 PM Ismaël Mejía wrote: > done > > On Tue, Feb 11, 2020 at 10:58 AM Shoaib Zafar < > shoaib.za...@venturedive.com> wrote: > >> Hi

Re: Labels on PR

2020-02-11 Thread jincheng sun
I left comments on PR, the main suggestion is that we may need a discussion about what kind of labels should be add. I would like to share my thoughts as follows: I think we need to add labels according to some rules. For example, the easiest way is to add labels by languages, java / python / go

Re: Jenkins Jobs Trigger Request

2020-02-11 Thread Ismaël Mejía
done On Tue, Feb 11, 2020 at 10:58 AM Shoaib Zafar wrote: > Hi everyone, > > I appreciate if someone could trigger the jobs for this PR: > https://github.com/apache/beam/pull/10712 > > Thanks. > > *Shoaib Zafar* > Software Engineering Lead > Mobile: +92 333 274 6242 > Skype: live:shoaibzafar_1

Re: Sphinx Docs Command Error (:sdks:python:test-suites:tox:pycommon:docs)

2020-02-11 Thread jincheng sun
I have verified that this issue could be reproduced in my local environment (MacOS) and the solution suggested by Udi could work! Best, Jincheng Udi Meiri 于2020年2月11日周二 上午8:51写道: > I don't have those issues (running on Linux), but a possible workaround > could be to remove the "-j 8" flags (2

Re: Labels on PR

2020-02-11 Thread Ismaël Mejía
Let some comments too, let's keep the discussion on refinements in the PR. On Tue, Feb 11, 2020 at 9:13 AM jincheng sun wrote: > I left comments on PR, the main suggestion is that we may need a > discussion about what kind of labels should be add. I would like to share > my thoughts as follows:

Re: Sphinx Docs Command Error (:sdks:python:test-suites:tox:pycommon:docs)

2020-02-11 Thread Shoaib Zafar
Thanks, Udi and Jincheng for the response. The suggested solution worked for me as well. Regards, *Shoaib Zafar* Software Engineering Lead Mobile: +92 333 274 6242 Skype: live:shoaibzafar_1 On Tue, Feb 11, 2020 at 1:17 PM jincheng sun wrote: > I have verified that

Jenkins Jobs Trigger Request

2020-02-11 Thread Shoaib Zafar
Hi everyone, I appreciate if someone could trigger the jobs for this PR: https://github.com/apache/beam/pull/10712 Thanks. *Shoaib Zafar* Software Engineering Lead Mobile: +92 333 274 6242 Skype: live:shoaibzafar_1

Re: Labels on PR

2020-02-11 Thread Ismaël Mejía
> So I propose going simple with a limited set of labels. Later on we can refine. Don't forget that does labels only are useful during the life-cycle of a PR. Labels are handy for quick filtering and finding PRs we care about for example to review. I agree with the feeling that we should not go

Re: Labels on PR

2020-02-11 Thread Alex Van Boxel
I'm wondering if we're not taking it too far with those detailed labels. It's like going from nothing to super details. The simples use-case hasn't proven itself in practice yet. So I propose going simple with a limited set of labels. Later on we can refine. Don't forget that does labels only are

Re: Transitive dependency from external repository

2020-02-11 Thread Alexey Romanenko
Thanks all for suggestions! For now, I just added another option to “JavaNatureConfiguration” and some logic into “pom.withXml" function. I created a PR about that: https://github.com/apache/beam/pull/10832 > On 7 Feb 2020, at 01:06, Luke Cwik

Re: Labels on PR

2020-02-11 Thread Robert Bradshaw
+1 to finding the right balance. I do think per-runner makes sense, rather than a general "runners." IOs might make sense as well. Not sure about all the extensions-* I'd leave those out for now. On Tue, Feb 11, 2020 at 5:56 AM Ismaël Mejía wrote: > > > So I propose going simple with a limited

Re: FnAPI proto backwards compatibility

2020-02-11 Thread Robert Bradshaw
On Mon, Feb 10, 2020 at 7:35 PM Kenneth Knowles wrote: > > On the runner requirements side: if you have such a list at the pipeline > level, it is an opportunity for the list to be inconsistent with the contents > of the pipeline. For example, if a DoFn is marked "requires stable input" but >

Unable to get java presubmit to run (not pass)

2020-02-11 Thread Daniel Collins
Hello beam developers, I've been trying to rerun presubmits on https://github.com/apache/beam/pull/10476 quite a few times, but it keeps stalling out at the "Java ("Run Java PreCommit") Pending — Build triggered for merge commit." Is there currently a problem with the jenkins cluster? Thanks!

Re: Sphinx Docs Command Error (:sdks:python:test-suites:tox:pycommon:docs)

2020-02-11 Thread Ahmet Altay
Should we remove the "-j 8" option by default? Sphinx docs says this is an experimental option [1]. I do not recall docs generation taking a long time, does this increase significantly without this option? [1] http://www.sphinx-doc.org/en/stable/man/sphinx-build.html On Tue, Feb 11, 2020 at 1:16

Re: Unable to get java presubmit to run (not pass)

2020-02-11 Thread Yifan Zou
I tried 'Run Java PreCommit' in the PR and it created the job #1734 in https://builds.apache.org/view/A-D/view/Beam/view/All/job/beam_PreCommit_Java_Phrase/. The job is in the waiting queue right now. But, I am not sure why the `Retest this please` failed executing all necessary tests. On Tue,

Cross-language pipelines status

2020-02-11 Thread Alexey Romanenko
Hi all, I just wanted to ask for more details about the status of cross-language pipelines (rather, transforms). I see some discussions about that here, but I think it’s more around cross-language IOs. I’ll appreciate for any information about that topic and answers for these questions: - Are

Re: Upgrades gcsio to 2.0.0

2020-02-11 Thread Tomo Suzuki
> What prevents the usage of the newer version of Guava? Cassandra is referencing an old field of Guava's CharMatcher. The field "DIGIT" is no longer available after Guava 26. https://github.com/apache/beam/pull/10769#issuecomment-583698718 On Mon, Feb 10, 2020 at 5:39 PM Luke Cwik wrote: > >

Re: Sphinx Docs Command Error (:sdks:python:test-suites:tox:pycommon:docs)

2020-02-11 Thread Udi Meiri
For me the difference was about 20s longer (40s -> 60s approx). Not significant IMO On Tue, Feb 11, 2020 at 9:59 AM Ahmet Altay wrote: > Should we remove the "-j 8" option by default? Sphinx docs says this is an > experimental option [1]. I do not recall docs generation taking a long > time,

Re: Cross-language pipelines status

2020-02-11 Thread Heejong Lee
On Tue, Feb 11, 2020 at 9:37 AM Alexey Romanenko wrote: > Hi all, > > I just wanted to ask for more details about the status of cross-language > pipelines (rather, transforms). I see some discussions about that here, but > I think it’s more around cross-language IOs. > > I’ll appreciate for any

Re: Cross-language pipelines status

2020-02-11 Thread Chamikara Jayalath
On Tue, Feb 11, 2020 at 11:13 AM Heejong Lee wrote: > > > On Tue, Feb 11, 2020 at 9:37 AM Alexey Romanenko > wrote: > >> Hi all, >> >> I just wanted to ask for more details about the status of cross-language >> pipelines (rather, transforms). I see some discussions about that here, but >> I