Re: JIRA Committer Permissions

2020-04-27 Thread Kenneth Knowles
I think it would be very valuable to have a committer onboarding guide,
with info for both the committer and steps for PMC to take. I think the
wiki is the right place for it...

(two seconds of checking later)

It exists!
https://cwiki.apache.org/confluence/display/BEAM/Committer+onboarding+guide

By the time you read this, I hope to have added the links that Luke
suggested. We do need to remember to send this guide to new committers. And
potentially announce changes that existing committers may not have followed.

Kenn

On Mon, Apr 27, 2020 at 7:23 PM Luke Cwik  wrote:

> The Beam committer guide is about reviewing code and the "become a
> committer" is more about what we look for and not the process.
>
> Since this is common for all ASF projects, I suspect an ASF page may have
> this documented or should be updated to have this covered as well but
> didn't see it on the ASF new committers resources page[1] or on the
> developers & contributors overview[2].
>
> 1: https://www.apache.org/dev/new-committers-guide.html
> 2: https://www.apache.org/dev/index.html
>
> On Mon, Apr 27, 2020 at 3:32 PM Udi Meiri  wrote:
>
>> Should this step be added to our new committer guide?
>>
>> On Fri, Apr 24, 2020 at 6:21 PM Luke Cwik  wrote:
>>
>>> I noticed that several committers only had contributor level permissions
>>> and I went and updated your account permissions for the Beam project to be
>>> committer level. Feel free to let me know If you run into any issues.
>>>
>>> There were about ~25 accounts like this.
>>>
>>


Re: JIRA Committer Permissions

2020-04-27 Thread Luke Cwik
The Beam committer guide is about reviewing code and the "become a
committer" is more about what we look for and not the process.

Since this is common for all ASF projects, I suspect an ASF page may have
this documented or should be updated to have this covered as well but
didn't see it on the ASF new committers resources page[1] or on the
developers & contributors overview[2].

1: https://www.apache.org/dev/new-committers-guide.html
2: https://www.apache.org/dev/index.html

On Mon, Apr 27, 2020 at 3:32 PM Udi Meiri  wrote:

> Should this step be added to our new committer guide?
>
> On Fri, Apr 24, 2020 at 6:21 PM Luke Cwik  wrote:
>
>> I noticed that several committers only had contributor level permissions
>> and I went and updated your account permissions for the Beam project to be
>> committer level. Feel free to let me know If you run into any issues.
>>
>> There were about ~25 accounts like this.
>>
>


Re: Jira PR links not being generated?

2020-04-27 Thread Kyle Weaver
Slight correction.. Jira to Github links are back. Github to Jira links
(which were only recently added) are not being added.

On Mon, Apr 27, 2020 at 7:20 PM Kyle Weaver  wrote:

> Well, links seem to work again at least.
>
> On Mon, Apr 27, 2020 at 7:10 PM Kyle Weaver  wrote:
>
>> Thanks Pablo. I merged it. Everyone should keep an eye on Jira and the
>> mailing lists to make sure I didn't accidentally mess something up.
>>
>> On Mon, Apr 27, 2020 at 7:01 PM Pablo Estrada  wrote:
>>
>>> I added it to add a list of non-committers that can trigger tests from
>>> PR. I added like 100+, so they asked us to not do that : )
>>> I've approved your PR, Kyle.
>>>
>>> On Mon, Apr 27, 2020 at 3:33 PM Kyle Weaver  wrote:
>>>
 I made a PR for this, though I still haven't found sufficient
 explanation as to why we did not need this file last week, and now we do
 this week. https://github.com/apache/beam/pull/11541

 On Mon, Apr 27, 2020 at 6:24 PM Udi Meiri  wrote:

> We had such a file for a short while but it was removed:
> https://github.com/apache/beam/pull/10645
> I don't believe it contained any PR link settings though
> +Pablo Estrada 
>
> On Mon, Apr 27, 2020 at 1:56 PM Kyle Weaver 
> wrote:
>
>> I went ahead and filed
>> https://issues.apache.org/jira/browse/BEAM-9833 since it looks like
>> this is how things will be done from now on. Which raises the question,
>> does anyone know how Beam managed these settings before? Or were there
>> previously no project-level controls?
>>
>> On Mon, Apr 27, 2020 at 4:39 PM Kyle Weaver 
>> wrote:
>>
>>> Thanks for the pointer Kenn. I searched existing INFRA issues and
>>> found [1] (among others). Looks like we may need to add a .asf.yaml file
>>> [2]. I guess infra must have changed this recently without us picking 
>>> up on
>>> it?
>>> 
>>>
>>> [1] https://issues.apache.org/jira/browse/INFRA-20171
>>> [2]
>>> https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories#id-.asf.yamlfeaturesforgitrepositories-Notificationsettingsforrepositories
>>>
>>> On Mon, Apr 27, 2020 at 4:25 PM Kenneth Knowles 
>>> wrote:
>>>
 I suggest filing an issue with INFRA.

 Kenn

 On Fri, Apr 24, 2020 at 10:12 AM Kyle Weaver 
 wrote:

> Hi all,
>
> I've noticed links from Jira issues to related Github PRs have not
> been generated the past few days. Does anyone know why?
>
> Kyle
>



Re: Jira PR links not being generated?

2020-04-27 Thread Kyle Weaver
Well, links seem to work again at least.

On Mon, Apr 27, 2020 at 7:10 PM Kyle Weaver  wrote:

> Thanks Pablo. I merged it. Everyone should keep an eye on Jira and the
> mailing lists to make sure I didn't accidentally mess something up.
>
> On Mon, Apr 27, 2020 at 7:01 PM Pablo Estrada  wrote:
>
>> I added it to add a list of non-committers that can trigger tests from
>> PR. I added like 100+, so they asked us to not do that : )
>> I've approved your PR, Kyle.
>>
>> On Mon, Apr 27, 2020 at 3:33 PM Kyle Weaver  wrote:
>>
>>> I made a PR for this, though I still haven't found sufficient
>>> explanation as to why we did not need this file last week, and now we do
>>> this week. https://github.com/apache/beam/pull/11541
>>>
>>> On Mon, Apr 27, 2020 at 6:24 PM Udi Meiri  wrote:
>>>
 We had such a file for a short while but it was removed:
 https://github.com/apache/beam/pull/10645
 I don't believe it contained any PR link settings though
 +Pablo Estrada 

 On Mon, Apr 27, 2020 at 1:56 PM Kyle Weaver 
 wrote:

> I went ahead and filed https://issues.apache.org/jira/browse/BEAM-9833 
> since
> it looks like this is how things will be done from now on. Which raises 
> the
> question, does anyone know how Beam managed these settings before? Or were
> there previously no project-level controls?
>
> On Mon, Apr 27, 2020 at 4:39 PM Kyle Weaver 
> wrote:
>
>> Thanks for the pointer Kenn. I searched existing INFRA issues and
>> found [1] (among others). Looks like we may need to add a .asf.yaml file
>> [2]. I guess infra must have changed this recently without us picking up 
>> on
>> it?
>> 
>>
>> [1] https://issues.apache.org/jira/browse/INFRA-20171
>> [2]
>> https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories#id-.asf.yamlfeaturesforgitrepositories-Notificationsettingsforrepositories
>>
>> On Mon, Apr 27, 2020 at 4:25 PM Kenneth Knowles 
>> wrote:
>>
>>> I suggest filing an issue with INFRA.
>>>
>>> Kenn
>>>
>>> On Fri, Apr 24, 2020 at 10:12 AM Kyle Weaver 
>>> wrote:
>>>
 Hi all,

 I've noticed links from Jira issues to related Github PRs have not
 been generated the past few days. Does anyone know why?

 Kyle

>>>


Re: Jira PR links not being generated?

2020-04-27 Thread Kyle Weaver
Thanks Pablo. I merged it. Everyone should keep an eye on Jira and the
mailing lists to make sure I didn't accidentally mess something up.

On Mon, Apr 27, 2020 at 7:01 PM Pablo Estrada  wrote:

> I added it to add a list of non-committers that can trigger tests from PR.
> I added like 100+, so they asked us to not do that : )
> I've approved your PR, Kyle.
>
> On Mon, Apr 27, 2020 at 3:33 PM Kyle Weaver  wrote:
>
>> I made a PR for this, though I still haven't found sufficient explanation
>> as to why we did not need this file last week, and now we do this week.
>> https://github.com/apache/beam/pull/11541
>>
>> On Mon, Apr 27, 2020 at 6:24 PM Udi Meiri  wrote:
>>
>>> We had such a file for a short while but it was removed:
>>> https://github.com/apache/beam/pull/10645
>>> I don't believe it contained any PR link settings though
>>> +Pablo Estrada 
>>>
>>> On Mon, Apr 27, 2020 at 1:56 PM Kyle Weaver  wrote:
>>>
 I went ahead and filed https://issues.apache.org/jira/browse/BEAM-9833 
 since
 it looks like this is how things will be done from now on. Which raises the
 question, does anyone know how Beam managed these settings before? Or were
 there previously no project-level controls?

 On Mon, Apr 27, 2020 at 4:39 PM Kyle Weaver 
 wrote:

> Thanks for the pointer Kenn. I searched existing INFRA issues and
> found [1] (among others). Looks like we may need to add a .asf.yaml file
> [2]. I guess infra must have changed this recently without us picking up 
> on
> it?
> 
>
> [1] https://issues.apache.org/jira/browse/INFRA-20171
> [2]
> https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories#id-.asf.yamlfeaturesforgitrepositories-Notificationsettingsforrepositories
>
> On Mon, Apr 27, 2020 at 4:25 PM Kenneth Knowles 
> wrote:
>
>> I suggest filing an issue with INFRA.
>>
>> Kenn
>>
>> On Fri, Apr 24, 2020 at 10:12 AM Kyle Weaver 
>> wrote:
>>
>>> Hi all,
>>>
>>> I've noticed links from Jira issues to related Github PRs have not
>>> been generated the past few days. Does anyone know why?
>>>
>>> Kyle
>>>
>>


Re: Jira PR links not being generated?

2020-04-27 Thread Pablo Estrada
I added it to add a list of non-committers that can trigger tests from PR.
I added like 100+, so they asked us to not do that : )
I've approved your PR, Kyle.

On Mon, Apr 27, 2020 at 3:33 PM Kyle Weaver  wrote:

> I made a PR for this, though I still haven't found sufficient explanation
> as to why we did not need this file last week, and now we do this week.
> https://github.com/apache/beam/pull/11541
>
> On Mon, Apr 27, 2020 at 6:24 PM Udi Meiri  wrote:
>
>> We had such a file for a short while but it was removed:
>> https://github.com/apache/beam/pull/10645
>> I don't believe it contained any PR link settings though
>> +Pablo Estrada 
>>
>> On Mon, Apr 27, 2020 at 1:56 PM Kyle Weaver  wrote:
>>
>>> I went ahead and filed https://issues.apache.org/jira/browse/BEAM-9833 since
>>> it looks like this is how things will be done from now on. Which raises the
>>> question, does anyone know how Beam managed these settings before? Or were
>>> there previously no project-level controls?
>>>
>>> On Mon, Apr 27, 2020 at 4:39 PM Kyle Weaver  wrote:
>>>
 Thanks for the pointer Kenn. I searched existing INFRA issues and found
 [1] (among others). Looks like we may need to add a .asf.yaml file [2]. I
 guess infra must have changed this recently without us picking up on it?
 

 [1] https://issues.apache.org/jira/browse/INFRA-20171
 [2]
 https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories#id-.asf.yamlfeaturesforgitrepositories-Notificationsettingsforrepositories

 On Mon, Apr 27, 2020 at 4:25 PM Kenneth Knowles 
 wrote:

> I suggest filing an issue with INFRA.
>
> Kenn
>
> On Fri, Apr 24, 2020 at 10:12 AM Kyle Weaver 
> wrote:
>
>> Hi all,
>>
>> I've noticed links from Jira issues to related Github PRs have not
>> been generated the past few days. Does anyone know why?
>>
>> Kyle
>>
>


Re: Jira PR links not being generated?

2020-04-27 Thread Udi Meiri
I think it's a recent change. The page https://s.apache.org/asfyaml-notify
was updated last week but I didn't see an announcement.

On Mon, Apr 27, 2020 at 3:34 PM Kyle Weaver  wrote:

> I made a PR for this, though I still haven't found sufficient explanation
> as to why we did not need this file last week, and now we do this week.
> https://github.com/apache/beam/pull/11541
>
> On Mon, Apr 27, 2020 at 6:24 PM Udi Meiri  wrote:
>
>> We had such a file for a short while but it was removed:
>> https://github.com/apache/beam/pull/10645
>> I don't believe it contained any PR link settings though
>> +Pablo Estrada 
>>
>> On Mon, Apr 27, 2020 at 1:56 PM Kyle Weaver  wrote:
>>
>>> I went ahead and filed https://issues.apache.org/jira/browse/BEAM-9833 since
>>> it looks like this is how things will be done from now on. Which raises the
>>> question, does anyone know how Beam managed these settings before? Or were
>>> there previously no project-level controls?
>>>
>>> On Mon, Apr 27, 2020 at 4:39 PM Kyle Weaver  wrote:
>>>
 Thanks for the pointer Kenn. I searched existing INFRA issues and found
 [1] (among others). Looks like we may need to add a .asf.yaml file [2]. I
 guess infra must have changed this recently without us picking up on it?
 

 [1] https://issues.apache.org/jira/browse/INFRA-20171
 [2]
 https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories#id-.asf.yamlfeaturesforgitrepositories-Notificationsettingsforrepositories

 On Mon, Apr 27, 2020 at 4:25 PM Kenneth Knowles 
 wrote:

> I suggest filing an issue with INFRA.
>
> Kenn
>
> On Fri, Apr 24, 2020 at 10:12 AM Kyle Weaver 
> wrote:
>
>> Hi all,
>>
>> I've noticed links from Jira issues to related Github PRs have not
>> been generated the past few days. Does anyone know why?
>>
>> Kyle
>>
>


smime.p7s
Description: S/MIME Cryptographic Signature


Re: Jira PR links not being generated?

2020-04-27 Thread Kyle Weaver
I made a PR for this, though I still haven't found sufficient explanation
as to why we did not need this file last week, and now we do this week.
https://github.com/apache/beam/pull/11541

On Mon, Apr 27, 2020 at 6:24 PM Udi Meiri  wrote:

> We had such a file for a short while but it was removed:
> https://github.com/apache/beam/pull/10645
> I don't believe it contained any PR link settings though
> +Pablo Estrada 
>
> On Mon, Apr 27, 2020 at 1:56 PM Kyle Weaver  wrote:
>
>> I went ahead and filed https://issues.apache.org/jira/browse/BEAM-9833 since
>> it looks like this is how things will be done from now on. Which raises the
>> question, does anyone know how Beam managed these settings before? Or were
>> there previously no project-level controls?
>>
>> On Mon, Apr 27, 2020 at 4:39 PM Kyle Weaver  wrote:
>>
>>> Thanks for the pointer Kenn. I searched existing INFRA issues and found
>>> [1] (among others). Looks like we may need to add a .asf.yaml file [2]. I
>>> guess infra must have changed this recently without us picking up on it?
>>> 
>>>
>>> [1] https://issues.apache.org/jira/browse/INFRA-20171
>>> [2]
>>> https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories#id-.asf.yamlfeaturesforgitrepositories-Notificationsettingsforrepositories
>>>
>>> On Mon, Apr 27, 2020 at 4:25 PM Kenneth Knowles  wrote:
>>>
 I suggest filing an issue with INFRA.

 Kenn

 On Fri, Apr 24, 2020 at 10:12 AM Kyle Weaver 
 wrote:

> Hi all,
>
> I've noticed links from Jira issues to related Github PRs have not
> been generated the past few days. Does anyone know why?
>
> Kyle
>



Re: JIRA Committer Permissions

2020-04-27 Thread Udi Meiri
Should this step be added to our new committer guide?

On Fri, Apr 24, 2020 at 6:21 PM Luke Cwik  wrote:

> I noticed that several committers only had contributor level permissions
> and I went and updated your account permissions for the Beam project to be
> committer level. Feel free to let me know If you run into any issues.
>
> There were about ~25 accounts like this.
>


smime.p7s
Description: S/MIME Cryptographic Signature


Re: Jira PR links not being generated?

2020-04-27 Thread Udi Meiri
We had such a file for a short while but it was removed:
https://github.com/apache/beam/pull/10645
I don't believe it contained any PR link settings though
+Pablo Estrada 

On Mon, Apr 27, 2020 at 1:56 PM Kyle Weaver  wrote:

> I went ahead and filed https://issues.apache.org/jira/browse/BEAM-9833 since
> it looks like this is how things will be done from now on. Which raises the
> question, does anyone know how Beam managed these settings before? Or were
> there previously no project-level controls?
>
> On Mon, Apr 27, 2020 at 4:39 PM Kyle Weaver  wrote:
>
>> Thanks for the pointer Kenn. I searched existing INFRA issues and found
>> [1] (among others). Looks like we may need to add a .asf.yaml file [2]. I
>> guess infra must have changed this recently without us picking up on it?
>> 
>>
>> [1] https://issues.apache.org/jira/browse/INFRA-20171
>> [2]
>> https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories#id-.asf.yamlfeaturesforgitrepositories-Notificationsettingsforrepositories
>>
>> On Mon, Apr 27, 2020 at 4:25 PM Kenneth Knowles  wrote:
>>
>>> I suggest filing an issue with INFRA.
>>>
>>> Kenn
>>>
>>> On Fri, Apr 24, 2020 at 10:12 AM Kyle Weaver 
>>> wrote:
>>>
 Hi all,

 I've noticed links from Jira issues to related Github PRs have not been
 generated the past few days. Does anyone know why?

 Kyle

>>>


smime.p7s
Description: S/MIME Cryptographic Signature


Re: Jira PR links not being generated?

2020-04-27 Thread Kyle Weaver
I went ahead and filed https://issues.apache.org/jira/browse/BEAM-9833 since
it looks like this is how things will be done from now on. Which raises the
question, does anyone know how Beam managed these settings before? Or were
there previously no project-level controls?

On Mon, Apr 27, 2020 at 4:39 PM Kyle Weaver  wrote:

> Thanks for the pointer Kenn. I searched existing INFRA issues and found
> [1] (among others). Looks like we may need to add a .asf.yaml file [2]. I
> guess infra must have changed this recently without us picking up on it?
> 
>
> [1] https://issues.apache.org/jira/browse/INFRA-20171
> [2]
> https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories#id-.asf.yamlfeaturesforgitrepositories-Notificationsettingsforrepositories
>
> On Mon, Apr 27, 2020 at 4:25 PM Kenneth Knowles  wrote:
>
>> I suggest filing an issue with INFRA.
>>
>> Kenn
>>
>> On Fri, Apr 24, 2020 at 10:12 AM Kyle Weaver  wrote:
>>
>>> Hi all,
>>>
>>> I've noticed links from Jira issues to related Github PRs have not been
>>> generated the past few days. Does anyone know why?
>>>
>>> Kyle
>>>
>>


Re: Jira PR links not being generated?

2020-04-27 Thread Kyle Weaver
Thanks for the pointer Kenn. I searched existing INFRA issues and found
[1] (among others). Looks like we may need to add a .asf.yaml file [2]. I
guess infra must have changed this recently without us picking up on it?


[1] https://issues.apache.org/jira/browse/INFRA-20171
[2]
https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories#id-.asf.yamlfeaturesforgitrepositories-Notificationsettingsforrepositories

On Mon, Apr 27, 2020 at 4:25 PM Kenneth Knowles  wrote:

> I suggest filing an issue with INFRA.
>
> Kenn
>
> On Fri, Apr 24, 2020 at 10:12 AM Kyle Weaver  wrote:
>
>> Hi all,
>>
>> I've noticed links from Jira issues to related Github PRs have not been
>> generated the past few days. Does anyone know why?
>>
>> Kyle
>>
>


Re: Jira PR links not being generated?

2020-04-27 Thread Kenneth Knowles
I suggest filing an issue with INFRA.

Kenn

On Fri, Apr 24, 2020 at 10:12 AM Kyle Weaver  wrote:

> Hi all,
>
> I've noticed links from Jira issues to related Github PRs have not been
> generated the past few days. Does anyone know why?
>
> Kyle
>


contributor permission for Beam Jira tickets

2020-04-27 Thread Darshan Jani
Hi,

This is Hai from Thoughtworks. I am currently working on consulting
and implementions of GCP, flink projects. We are also google partner.
Can someone add me as a contributor for Beam's Jira issue tracker? I
would like to create/assign tickets for my work.
I have created following JIRA issue in BEAM.
https://issues.apache.org/jira/browse/BEAM-9825

Thanks,
Darshan


Re: contributor permission for Beam Jira tickets

2020-04-27 Thread Luke Cwik
Welcome, I granted you contributor permissions and assigned BEAM-9825.

It looks like BEAM-9825 could have overlap with the Beam SQL effort because
it looks like different kinds of join functionality. Have you been in
contact with them?

On Mon, Apr 27, 2020 at 8:28 AM Darshan Jani 
wrote:

> Hi,
>
> Username : darshanjani
>
> -Regards
> Darshan
>
> On Mon, Apr 27, 2020 at 3:51 PM Darshan Jani 
> wrote:
>
>> Hi,
>>
>> This is Hai from Thoughtworks. I am currently working on consulting and 
>> implementions of GCP, flink projects. We are also google partner. Can 
>> someone add me as a contributor for Beam's Jira issue tracker? I would like 
>> to create/assign tickets for my work.
>> I have created following JIRA issue in BEAM.
>> https://issues.apache.org/jira/browse/BEAM-9825
>>
>> Thanks,
>> Darshan
>>
>>


Re: contributor permission for Beam Jira tickets

2020-04-27 Thread Darshan Jani
Hi,

Username : darshanjani

-Regards
Darshan

On Mon, Apr 27, 2020 at 3:51 PM Darshan Jani 
wrote:

> Hi,
>
> This is Hai from Thoughtworks. I am currently working on consulting and 
> implementions of GCP, flink projects. We are also google partner. Can someone 
> add me as a contributor for Beam's Jira issue tracker? I would like to 
> create/assign tickets for my work.
> I have created following JIRA issue in BEAM.
> https://issues.apache.org/jira/browse/BEAM-9825
>
> Thanks,
> Darshan
>
>


Re: Github PR links in JIRA

2020-04-27 Thread Ismaël Mejía
Also asked by Kyle
https://lists.apache.org/thread.html/rdb4dc0406f0767a3928125bf063a74ef94c985a8a41b0d4b8e6cbd77%40%3Cdev.beam.apache.org%3E

Probably worth to create an INFRA since I suppose that's on their side.

On Mon, Apr 27, 2020 at 1:02 PM Maximilian Michels  wrote:
>
> Hi everyone,
>
> Did anyone notice that GitHub PRs tagged with a JIRA issue
> ("[BEAM-XXX]") do not automatically get linked anymore in JIRA?
>
> Does anyone know how that stuff works?
>
> Thanks,
> Max


Beam Dependency Check Report (2020-04-27)

2020-04-27 Thread Apache Jenkins Server
ERROR: File 'src/build/dependencyUpdates/beam-dependency-check-report.html' does not exist

Github PR links in JIRA

2020-04-27 Thread Maximilian Michels
Hi everyone,

Did anyone notice that GitHub PRs tagged with a JIRA issue
("[BEAM-XXX]") do not automatically get linked anymore in JIRA?

Does anyone know how that stuff works?

Thanks,
Max