Re: Dynamic timers now supported!

2020-01-23 Thread Rehman Murad Ali
Thank you Reuven for the guidance throughout the development process. I am delighted to contribute my two cents to the Beam project. Looking forward to more active contributions. *Thanks & Regards* *Rehman Murad Ali* Software Engineer Mobile: +92 3452076766 Skype: rehman.muradali On Thu,

Re: Dynamic timers now supported!

2020-01-23 Thread Reza Rokni
Very cool ! Thank you Rehman! On Fri, 24 Jan 2020, 06:12 Maximilian Michels, wrote: > Great work! That makes timers so much easier to use and also adds new > use cases. Thank you Rehman. > > On 23.01.20 22:54, Robert Burke wrote: > > Fascinating and great work! *makes notes for an eventual Go

Re: Jenkins jobs not running for my PR 10438

2020-01-23 Thread Rui Wang
Done -Rui On Thu, Jan 23, 2020 at 2:45 PM Tomo Suzuki wrote: > Hi Beam Comitters, > > Can somebody trigger 2 failed checks below for > https://github.com/apache/beam/pull/10674 ? > Run Java PreCommit > Run JavaPortabilityApi PreCommit > > > On Thu, Jan 23, 2020 at 14:32 Tomo Suzuki wrote: >

Re: PreCommit Java Portability is failing

2020-01-23 Thread Hannah Jiang
Yes, ths fix was merged at 2:30PM PST -ish. Happy it is confirmed. On Thu, Jan 23, 2020 at 2:46 PM Tomo Suzuki wrote: > Hannah, > > Thank you for the fix (#10676)! > > On Thu, Jan 23, 2020 at 2:55 PM Hannah Jiang > wrote: > > > > I will submit a small patch this afternoon, the original PR to

Re: PreCommit Java Portability is failing

2020-01-23 Thread Tomo Suzuki
Hannah, Thank you for the fix (#10676)! On Thu, Jan 23, 2020 at 2:55 PM Hannah Jiang wrote: > > I will submit a small patch this afternoon, the original PR to fix this issue > needs some time to merge. > > > On Thu, Jan 23, 2020 at 11:33 AM Andrew Pilloud wrote: >> >> This is still hard

Re: Jenkins jobs not running for my PR 10438

2020-01-23 Thread Tomo Suzuki
Hi Beam Comitters, Can somebody trigger 2 failed checks below for https://github.com/apache/beam/pull/10674 ? Run Java PreCommit Run JavaPortabilityApi PreCommit On Thu, Jan 23, 2020 at 14:32 Tomo Suzuki wrote: > Hi Rui, > (Thank you for quick response) > > Would you run one command per one

Re: Dynamic timers now supported!

2020-01-23 Thread Maximilian Michels
Great work! That makes timers so much easier to use and also adds new use cases. Thank you Rehman. On 23.01.20 22:54, Robert Burke wrote: Fascinating and great work! *makes notes for an eventual Go SDK implementation* On Thu, Jan 23, 2020, 1:51 PM Luke Cwik > wrote:

Re: Dynamic timers now supported!

2020-01-23 Thread Robert Burke
Fascinating and great work! *makes notes for an eventual Go SDK implementation* On Thu, Jan 23, 2020, 1:51 PM Luke Cwik wrote: > This is great. Thanks for the contribution Rehman. > > On Thu, Jan 23, 2020 at 10:09 AM Reuven Lax wrote: > >> Thanks to a lot of hard work by Rehman, Beam now

Re: Dynamic timers now supported!

2020-01-23 Thread Luke Cwik
This is great. Thanks for the contribution Rehman. On Thu, Jan 23, 2020 at 10:09 AM Reuven Lax wrote: > Thanks to a lot of hard work by Rehman, Beam now supports dynamic timers. > As a reminder, this was discussed on the dev list some time back. > > As background, previously one had to

Re: [Discuss] Beam Summit 2020 Dates & locations

2020-01-23 Thread Austin Bennett
We are working on it. Identifying initial funding sources and other bits necessary to help make this happen. On Wed, Jan 22, 2020, 7:14 PM Chad Dombrova wrote: > Hi all, > Did we come to a consensus on dates and locations for the summits? > Particularly interested in the North America Summit.

Re: help with this error, please

2020-01-23 Thread Vasu Nori
Luke, Toko Thanks for the responses. I will upload a change that is the minimum needed to reproduce this error. shortly. thanks, On Wed, Jan 22, 2020 at 7:48 PM Tomo Suzuki wrote: > Hi Vasu, > (Ignore my message if Luke's advice resolves the issue already) > > Would you add the entire error

Re: PreCommit Java Portability is failing

2020-01-23 Thread Hannah Jiang
I will submit a small patch this afternoon, the original PR to fix this issue needs some time to merge. On Thu, Jan 23, 2020 at 11:33 AM Andrew Pilloud wrote: > This is still hard failing on all Java PRs. Is there anything you can do > to mitigate this (disable the test) until it is fixed? > >

Re: Jenkins Master

2020-01-23 Thread Yifan Zou
Great! We'll follow up with Gavin to set up some nodes with the new master. On Thu, Jan 23, 2020 at 11:29 AM Pablo Estrada wrote: > That makes sense Yifan. I think that's fine, to use two new instances. > > On Thu, Jan 23, 2020 at 11:28 AM Yifan Zou wrote: > >> Thanks for updates on the

Re: [DISCUSS] Autoformat python code with Black

2020-01-23 Thread Robert Bradshaw
Thanks! Now we get to debate what knobs to twiddle :-P FYI, I did a simple run (just pushed to https://github.com/apache/beam/compare/master...robertwb:yapf) to see the impact. The diff is $ git diff --stat master ... 547 files changed, 22118 insertions(+), 21129 deletions(-) For

Re: Jenkins jobs not running for my PR 10438

2020-01-23 Thread Tomo Suzuki
Hi Rui, (Thank you for quick response) Would you run one command per one comment? I don't think Jenkins recognizes multiple at once. On Thu, Jan 23, 2020 at 2:25 PM Rui Wang wrote: > > Done > > On Thu, Jan 23, 2020 at 11:20 AM Tomo Suzuki wrote: >> >> Hi Beam Committers, >> >> I appreciate if

Re: PreCommit Java Portability is failing

2020-01-23 Thread Andrew Pilloud
This is still hard failing on all Java PRs. Is there anything you can do to mitigate this (disable the test) until it is fixed? Andrew On Tue, Jan 21, 2020 at 1:47 PM Hannah Jiang wrote: > This is caused by PR 10557 , I > will fix it soon. > > On Tue,

Re: Jenkins Master

2020-01-23 Thread Pablo Estrada
That makes sense Yifan. I think that's fine, to use two new instances. On Thu, Jan 23, 2020 at 11:28 AM Yifan Zou wrote: > Thanks for updates on the Jenkins infrastructures! > The Beam nodes are currently connected via JNLP. Since all existing nodes > are heavy loaded, I'd prefer to have 1 or 2

Re: Jenkins Master

2020-01-23 Thread Yifan Zou
Thanks for updates on the Jenkins infrastructures! The Beam nodes are currently connected via JNLP. Since all existing nodes are heavy loaded, I'd prefer to have 1 or 2 temporal instances boot by the most recent disk image for testing purposes. Thoughts? Objections? -yifan On Thu, Jan 23, 2020

[RESULT] [VOTE] Release 2.18.0, release candidate #1

2020-01-23 Thread Udi Meiri
I'm happy to announce that we have unanimously approved this release. There are 5 approving votes, 4 of which are binding: * Ahmet Altay * Robert Bradshaw * Ismaël Mejía * Jean-Baptiste Onofré There are no disapproving votes. Thanks everyone! smime.p7s Description: S/MIME Cryptographic

Re: Jenkins jobs not running for my PR 10438

2020-01-23 Thread Rui Wang
Done On Thu, Jan 23, 2020 at 11:20 AM Tomo Suzuki wrote: > Hi Beam Committers, > > I appreciate if you can run precommit checks for > https://github.com/apache/beam/pull/10674 > plus the following 6 extra commands: > > Run Java PostCommit > Run Java HadoopFormatIO Performance Test > Run

Re: Jenkins jobs not running for my PR 10438

2020-01-23 Thread Tomo Suzuki
Hi Beam Committers, I appreciate if you can run precommit checks for https://github.com/apache/beam/pull/10674 plus the following 6 extra commands: Run Java PostCommit Run Java HadoopFormatIO Performance Test Run BigQueryIO Streaming Performance Test Java Run Dataflow ValidatesRunner Run Spark

Re: Jenkins Master

2020-01-23 Thread Ahmet Altay
/cc +Alan Myrvold +Yifan Zou +Dan Gazineu -- cc'ing folks who worked on Jenkins related tasks before. On Thu, Jan 23, 2020 at 10:10 AM Pablo Estrada wrote: > Removing private@, and adding dev@. > > ASF Infra has provisioned a new Jenkins master that we'll be able to use > with more

Re: Jenkins Master

2020-01-23 Thread Pablo Estrada
Removing private@, and adding dev@. ASF Infra has provisioned a new Jenkins master that we'll be able to use with more independence. Now we can start by testing a couple workers on it, and eventually moving all of our workers. Is anyone available to engage with Gavin in moving this forward? Best

Re: Jenkins jobs not running for my PR 10438

2020-01-23 Thread Rui Wang
Done On Thu, Jan 23, 2020 at 9:09 AM Rehman Murad Ali < rehman.murad...@venturedive.com> wrote: > Hi Committer, > > I appreciate if you could trigger jobs for > https://github.com/apache/beam/pull/10627 > > > > > *Thanks & Regards* > > > > *Rehman Murad Ali* > Software Engineer > Mobile: +92

Dynamic timers now supported!

2020-01-23 Thread Reuven Lax
Thanks to a lot of hard work by Rehman, Beam now supports dynamic timers. As a reminder, this was discussed on the dev list some time back. As background, previously one had to statically declare all timers in your code. So if you wanted to have two timers, you needed to create two timer

Re: [VOTE] Release 2.18.0, release candidate #1

2020-01-23 Thread Thomas Weise
I don't have anything conclusive yet; it could also be related to our infra. I would not block the release. Thomas On Wed, Jan 22, 2020 at 1:01 PM Udi Meiri wrote: > Thomas, please let us know if you learn more about possible root causes to > the regression you're seeing. > Also, if you

Re: Jenkins jobs not running for my PR 10438

2020-01-23 Thread Rehman Murad Ali
Hi Committer, I appreciate if you could trigger jobs for https://github.com/apache/beam/pull/10627 *Thanks & Regards* *Rehman Murad Ali* Software Engineer Mobile: +92 3452076766 Skype: rehman.muradali On Wed, Jan 22, 2020 at 5:18 AM Kirill Kozlov wrote: > Thank you Rui and Ankur! > >

Re: Java Build broken

2020-01-23 Thread Maximilian Michels
Do you have any overrides in your ~/.m2/settings.xml? The artifacts should be found as part of Maven central, e.g. https://mvnrepository.com/artifact/com.google.errorprone/error_prone_check_api Cheers, Max On 23.01.20 11:11, Stefan Djelekar wrote: Hi guys, It’s been days now since the build

Re: New contributor

2020-01-23 Thread Ismaël Mejía
Done. Welcome to Beam! On Thu, Jan 23, 2020 at 1:58 PM Nicholas Got wrote: > Hi, > > This is Nicholas Got. Can someone add me as a contributor for Beam's Jira > issue tracker? I would like to create/assign tickets for my work. ASF Jira > username: ngot > > Regards, > Nicholas Got >

New contributor

2020-01-23 Thread Nicholas Got
Hi, This is Nicholas Got. Can someone add me as a contributor for Beam's Jira issue tracker? I would like to create/assign tickets for my work. ASF Jira username: ngot Regards, Nicholas Got

Re: Ordering of element timestamp change and window function

2020-01-23 Thread Jan Lukavský
Hi Reuven, > Your first statement is partially true, but the second statement doesn't follow from that. Stateful DoFn is in some sense a more general transform, yes. However that doesn't mean that semantics should be defined in terms of stateful DoFn. There are other ways of implementing

Re: [DISCUSS] Autoformat python code with Black

2020-01-23 Thread Kamil Wasilewski
Thank you Michał for creating the ticket. I have some free time and I'd like to volunteer myself for this task. Indeed, it looks like there's consensus for `yapf`, so I'll try `yapf` first. Best, Kamil On Thu, Jan 23, 2020 at 10:37 AM Michał Walenia wrote: > Hi all, > I created a JIRA issue

Re: [DISCUSS] Autoformat python code with Black

2020-01-23 Thread Ismaël Mejía
Great to see general consensus and this finally happening! I think there is less arguments now about the tool with a consensus towards `yapf`. So better just to do a PoC with `yapf` tuned to the Beam's configuration to see how impacting it would be. Thanks Michal and Kamil for taking a look into

Re: [DISCUSS] Autoformat python code with Black

2020-01-23 Thread Michał Walenia
Hi all, I created a JIRA issue for this and summarized the available tools https://issues.apache.org/jira/browse/BEAM-9175 Cheers, Michal On Thu, Jan 23, 2020 at 1:49 AM Udi Meiri wrote: > Sorry, backing off on this due to time constraints. > > On Wed, Jan 22, 2020 at 3:39 PM Udi Meiri

Re: Ordering of element timestamp change and window function

2020-01-23 Thread Reuven Lax
On Wed, Jan 22, 2020 at 11:37 PM Jan Lukavský wrote: > Hi Kenn, > > I do not agree with the last part. We are talking about definition of > semantics. If GBK can be implemented on top of stateful dofn, then stateful > dofn is the more generic transform. Therefore, semantics should be defined >