Re: All validates runner tests seems to be broken.

2019-05-14 Thread Michael Luckey
To clarify: These failures are expected. And not much we can do abou. It is just that I did forget about the consequences for the ongoing release. (Sorry again, Ankur!) Apart from that, testing was done on local Jenkins setup to not mess with the global configuration. As this would have blocked

Re: All validates runner tests seems to be broken.

2019-05-14 Thread Andrew Pilloud
The specific issue in your text appears to be a typo introduced in https://github.com/apache/beam/pull/8194 While that PR ran a bunch of tests, I didn't see a reference to "Run Seed Job", which means it didn't actually test the code in the change. I expect not all the failures are the same as

Re: All validates runner tests seems to be broken.

2019-05-14 Thread Michael Luckey
Created reverting PR https://github.com/apache/beam/pull/8581 You might approve and merge. On Tue, May 14, 2019 at 11:19 PM Ankur Goenka wrote: > Ahh, I see. Good point. > so shall we revert test-infra? > > *From: *Alan Myrvold > *Date: *Tue, May 14, 2019 at 2:16 PM > *To: * > > Other ones

Re: All validates runner tests seems to be broken.

2019-05-14 Thread Ankur Goenka
It seems to be related. I will try to rerun the seed job. *From: *Lukasz Cwik *Date: *Tue, May 14, 2019 at 1:52 PM *To: *dev Its likely related to the rename done in > https://github.com/apache/beam/commit/f198de033824949eb66ea533ae8a40b8dd8cd7fe#diff-2bb618406f7ee4470a48343283f368a2 > Kenn is

Re: All validates runner tests seems to be broken.

2019-05-14 Thread Michael Luckey
Unfortunately, I missed the fact that seed job triggers automatically. Yes, you need to run the seed job on your branch to replace the old commands. We might consider resetting to legacy commands, i.e. revert ./test-infra folder. What do you think? On Tue, May 14, 2019 at 11:02 PM Andrew

Re: All validates runner tests seems to be broken.

2019-05-14 Thread Alan Myrvold
Other ones are failing on the branch due to the 2.13.0 branch not having https://github.com/apache/beam/pull/8194, and the seed job running from master. *From: *Michael Luckey *Date: *Tue, May 14, 2019 at 2:13 PM *To: * Unfortunately, I missed the fact that seed job triggers automatically. > >

Re: All validates runner tests seems to be broken.

2019-05-14 Thread Ankur Goenka
yup, running the seed job. @Alan Myrvold The other tests are also failing which do not have a typo, *From: *Andrew Pilloud *Date: *Tue, May 14, 2019 at 2:02 PM *To: *dev So it sounds like a number of the failures are related to a single jenkins > config for all branches. This means you can't

Re: All validates runner tests seems to be broken.

2019-05-14 Thread Ankur Goenka
Ahh, I see. Good point. so shall we revert test-infra? *From: *Alan Myrvold *Date: *Tue, May 14, 2019 at 2:16 PM *To: * Other ones are failing on the branch due to the 2.13.0 branch not having > https://github.com/apache/beam/pull/8194, and the seed job running from > master. > > *From:

Re: All validates runner tests seems to be broken.

2019-05-14 Thread Alan Myrvold
That is a typo added in https://github.com/apache/beam/pull/8194 https://github.com/apache/beam/commit/1e7ea0da5073566c3fa26dbc1105105fbe6043ae#diff-9591f0d06e82e711681fd77ed287578b *From: *Ankur Goenka *Date: *Tue, May 14, 2019 at 1:43 PM *To: *dev Hi, > > Following tests seems to be broken

Re: All validates runner tests seems to be broken.

2019-05-14 Thread Andrew Pilloud
So it sounds like a number of the failures are related to a single jenkins config for all branches. This means you can't test the release branch if the targets change after it is cut. One possibility: do "Run Seed Job" on the release branch and kick off all the tests right after that finishes.

Re: All validates runner tests seems to be broken.

2019-05-14 Thread Lukasz Cwik
Its likely related to the rename done in https://github.com/apache/beam/commit/f198de033824949eb66ea533ae8a40b8dd8cd7fe#diff-2bb618406f7ee4470a48343283f368a2 Kenn is tracking a different issue related to publishing being broken in BEAM-7302 which he has a fix for in

All validates runner tests seems to be broken.

2019-05-14 Thread Ankur Goenka
Hi, Following tests seems to be broken because of "Project 'unners' not found in root project 'beam'." The command getting executed on Jenkins is gradlew --continue --max-workers=12 -Dorg.gradle.jvmargs=-Xms2g -Dorg.gradle.jvmargs=-Xmx4g :unners:samza:validatesRunner causing the failure. The same