Re: Code Coverage Tracking

2020-05-26 Thread Tyson Hamilton
Huh.. I just realized it is closed already, now I'm confused. On 2020/05/26 15:08:21, Tyson Hamilton wrote: > Yes, this would be a good choice for the fixit. The tracking issue exists > already too: > > https://issues.apache.org/jira/browse/BEAM-1132 > > On 2020/05/26 14:00:00, Kenneth

Re: Code Coverage Tracking

2020-05-26 Thread Tyson Hamilton
Yes, this would be a good choice for the fixit. The tracking issue exists already too: https://issues.apache.org/jira/browse/BEAM-1132 On 2020/05/26 14:00:00, Kenneth Knowles wrote: > We tried coveralls (I also used it in a few past projects) and it did not > really work for us. A service

Re: Code Coverage Tracking

2020-05-26 Thread Luke Cwik
Its integrated and available as part of the Jenkins UI: https://builds.apache.org/view/A-D/view/Beam/view/PostCommit/job/beam_PreCommit_Java_Cron/lastBuild/jacoco/ On Tue, May 26, 2020 at 8:10 AM Tyson Hamilton wrote: > Huh.. I just realized it is closed already, now I'm confused. > > On

Re: Code Coverage Tracking

2020-05-26 Thread Kenneth Knowles
We tried coveralls (I also used it in a few past projects) and it did not really work for us. A service that I really like is codecov.io (and they have a chrome plugin to overlay coverage on PRs) but the granularity of GitHub permissions was a problem in the past (most GitHub apps require blanket

Code Coverage Tracking

2020-05-20 Thread Tyson Hamilton
Hello, I noticed on the github page, there is a badge that reports 100% coverage. This seems suspect, and sure enough after a couple clicks coverall shows that only one file is tracked. A more interesting page is the Builds page [1] that shows the impact of specific PRs. It would be really