Re: Filtered Pre-commit triggering is BACK!

2018-06-29 Thread Reuven Lax
Yeah, this last one took 20 minutes to trigger :( On Fri, Jun 29, 2018 at 9:25 AM Scott Wegner wrote: > GitHub triggering continues to be delayed intermittently. I've filed a > JIRA to track: https://issues.apache.org/jira/browse/BEAM-4692. JB, can > you link any ticket you have with INFRA for t

Re: Filtered Pre-commit triggering is BACK!

2018-06-29 Thread Scott Wegner
GitHub triggering continues to be delayed intermittently. I've filed a JIRA to track: https://issues.apache.org/jira/browse/BEAM-4692. JB, can you link any ticket you have with INFRA for those that are affected to keep track? Robin, I looked at your PR#5787 which ran all pre-commits instead of jus

Re: Filtered Pre-commit triggering is BACK!

2018-06-28 Thread Jean-Baptiste Onofré
It failed again. I'm pinging infra a new time. Sorry about that. Regards JB Le 29 juin 2018 à 08:52, à 08:52, Reuven Lax a écrit: >"retest this please" also seems to not be working right now. > >On Thu, Jun 28, 2018 at 5:49 PM Reuven Lax wrote: > >> I've pushed changes that definitely affect c

Re: Filtered Pre-commit triggering is BACK!

2018-06-28 Thread Reuven Lax
"retest this please" also seems to not be working right now. On Thu, Jun 28, 2018 at 5:49 PM Reuven Lax wrote: > I've pushed changes that definitely affect code, and seen no tests at all > being triggered. I also wonder if something isn't working quite right with > this filtering. > > On Thu, Ju

Re: Filtered Pre-commit triggering is BACK!

2018-06-28 Thread Reuven Lax
I've pushed changes that definitely affect code, and seen no tests at all being triggered. I also wonder if something isn't working quite right with this filtering. On Thu, Jun 28, 2018 at 5:16 PM Robin Qiu wrote: > My PR with only changes in Java also triggered Python ("Run Python > PreCommit")

Re: Filtered Pre-commit triggering is BACK!

2018-06-28 Thread Robin Qiu
My PR with only changes in Java also triggered Python ("Run Python PreCommit") and Go ("Run Go PreCommit") tests. Is that the expected behavior? https://github.com/apache/beam/pull/5787 On Wed, Jun 27, 2018 at 5:04 PM Ahmet Altay wrote: > Two of my PRs with python changes did not trigger any pre

Re: Filtered Pre-commit triggering is BACK!

2018-06-27 Thread Ahmet Altay
Two of my PRs with python changes did not trigger any pre-commits. Could it be related to this change? https://github.com/apache/beam/pull/5768 https://github.com/apache/beam/pull/5800 Ahmet On Tue, Jun 26, 2018 at 2:30 PM, Andrew Pilloud wrote: > Awesome! This will save so much time running

Re: Filtered Pre-commit triggering is BACK!

2018-06-26 Thread Andrew Pilloud
Awesome! This will save so much time running tests. On Tue, Jun 26, 2018 at 2:29 PM Yifan Zou wrote: > Thanks Scott! It's nice to have this feature. > > On Tue, Jun 26, 2018 at 2:24 PM Pablo Estrada wrote: > >> This is great. Reducing load on infrastructure should help Beam scale >> into a larg

Re: Filtered Pre-commit triggering is BACK!

2018-06-26 Thread Yifan Zou
Thanks Scott! It's nice to have this feature. On Tue, Jun 26, 2018 at 2:24 PM Pablo Estrada wrote: > This is great. Reducing load on infrastructure should help Beam scale into > a larger project : ) - Thanks Scott! > > On Tue, Jun 26, 2018 at 2:21 PM Scott Wegner wrote: > >> By popular demand [

Re: Filtered Pre-commit triggering is BACK!

2018-06-26 Thread Pablo Estrada
This is great. Reducing load on infrastructure should help Beam scale into a larger project : ) - Thanks Scott! On Tue, Jun 26, 2018 at 2:21 PM Scott Wegner wrote: > By popular demand [1], filtered pre-commit triggering is now re-enabled. > Now when submitting pull request, only pre-commit tests

Filtered Pre-commit triggering is BACK!

2018-06-26 Thread Scott Wegner
By popular demand [1], filtered pre-commit triggering is now re-enabled. Now when submitting pull request, only pre-commit tests for your affected files will run: if you change just the Go SDK, you'll no longer need to run Java pre-commits. Last time we introduced this change it regressed our abil