Re: PR/6343: Adding support for MustFollow

2018-09-10 Thread Maximilian Michels
This is a great idea but I share Lukasz' doubts about this being a universal solution for awaiting some action in a pipeline. I wonder, wouldn't it work to not pass in a PCollection, but instead wrap a DoFn which internally ensures the correct triggering behavior? All runners which correctly m

Re: PR/6343: Adding support for MustFollow

2018-09-07 Thread Peter Li
Thanks! I (PR author) agree with all that. On the unbounded triggering issue, I can see 2 reasonable desired behaviors: 1) The collection to follow is bounded and the intent is to wait for the entire collection to be processed. 2) The collection to follow has windows that in some flexible sen

PR/6343: Adding support for MustFollow

2018-09-07 Thread Lukasz Cwik
A contributor opened a PR[1] to add support for a PTransform that forces one PTransform to be executed before another by using side input readiness as a way to defer execution. They have provided this example usage: # Ensure that output dir is created before attempting to write output files. outpu