> it would be good to have a sort of weekly report on dead links
Seeing as checking for broken external links returns a lot of false
positives, I'd rather not spam everyone with them. However, I don't
know if making it a postcommit will give it sufficient visibility. Not
sure what the best way to
+1 to removing link validation for website changes. However it would be
good to have a sort of weekly report on dead links or another alternative
to be aware of them.
On Tue, Apr 16, 2019 at 2:43 AM Kyle Weaver wrote:
> I agree with Andrew that the external links checks are ultra-flaky and
>
I agree with Andrew that the external links checks are ultra-flaky and
seldom strictly needed, so I filed a PR to make checking external links
optional and disabled by default: https://github.com/apache/beam/pull/8318.
Let me know what you all think.
Kyle Weaver ️ Software Engineer ️
+1 thanks for noticing and raising yet another source of non-hermeticity
(plus the docker constraint)
On Mon, Apr 1, 2019 at 9:09 AM Andrew Pilloud wrote:
> +1 on this, particularly removing the dead link checker from default
> tests. It is effectively testing that ~20 random websites are up. I
+1 if possible, removing link checks would be nice too, if they are
unreliable and there is a way to disable them.
On Mon, Apr 1, 2019 at 10:33 AM Mikhail Gryzykhin wrote:
> +1 on this. I'd prefer to have this as pre-commit only.
>
> On Mon, Apr 1, 2019 at 9:09 AM Andrew Pilloud wrote:
>
>> +1
+1 on this. I'd prefer to have this as pre-commit only.
On Mon, Apr 1, 2019 at 9:09 AM Andrew Pilloud wrote:
> +1 on this, particularly removing the dead link checker from default
> tests. It is effectively testing that ~20 random websites are up. I wonder
> if there is a way to limit it to
+1 on this, particularly removing the dead link checker from default tests.
It is effectively testing that ~20 random websites are up. I wonder if
there is a way to limit it to locally testing links within the beam site?
On Mon, Apr 1, 2019 at 3:54 AM Michael Luckey wrote:
> Hi,
>
> after
Hi,
after playing around with Gradle build for a while, I would like to suggest
to remove ':beam-website:testWebsite target from Gradle's check task.
Rationale:
- the task seems to be very flaky. In fact, I always need to add '-x
:beam-website:testWebsite' to my build [1]
- task uses docker,
