Re: Beam IO: suggestions and new features

2016-09-19 Thread Jean-Baptiste Onofré
Hi Eugene, thanks for your feedbacks. See my comments: 1/ I now have a better understanding the logic/steps to write IO and as a IO Developer, it's not really a problem. My concern is more when you have to build an application on top of Beam (like for instance a DSL). Then, we can identify

Re: Issues with simple KafkaIO-read pipeline -- where to write?

2016-09-19 Thread Dan Halperin
+dev On Mon, Sep 19, 2016 at 4:37 PM, Dan Halperin wrote: > Hey folks, > > Sorry for the confusion around sinks. Let me see if I can clear things up. > > In Beam, a Source+Reader is a very integral part of the model. A source is > the root of a pipeline and it is where

IntervalWindow toString()

2016-09-19 Thread Jesse Anderson
The toString() to IntervalWindow starts with a square bracket and ends with a parenthesis. Is this a type of notation or a bug? Code: @Override public String toString() { return "[" + start + ".." + end + ")"; } Thanks, Jesse

Re: IntervalWindow toString()

2016-09-19 Thread Ben Chambers
I think this is using http://www.mathwords.com/i/interval_notation.htm to indicate that the interval includes the start time but not the end time. On Mon, Sep 19, 2016, 8:56 AM Jesse Anderson wrote: > The toString() to IntervalWindow starts with a square bracket and ends

Re: IntervalWindow toString()

2016-09-19 Thread Amit Sela
Looks like included, excluded bounds. On Mon, Sep 19, 2016, 18:57 Jesse Anderson wrote: > The toString() to IntervalWindow starts with a square bracket and ends with > a parenthesis. Is this a type of notation or a bug? Code: > > @Override > public String toString() {

Re: IntervalWindow toString()

2016-09-19 Thread Lukasz Cwik
Follows math conventions that represent ranges where [ ] represent inclusivity and ( ) means upto but don't include. So [2, 3) means the range from 2 upto but not including 3. On Mon, Sep 19, 2016 at 8:56 AM, Jesse Anderson wrote: > The toString() to IntervalWindow starts