I think JB and Davor are right, have heard other supporting votes, and I
haven't heard any specific disagreement.
My understanding of rules/procedure is that JB as release manager is free
to cancel the vote right now and begin RC2 when he is ready.
On Thu, Dec 15, 2016 at 11:36 AM, Jean-Baptiste
Looping back, all issues I know about or have mentioned are now on the
release branch.
On Thu, Dec 15, 2016 at 11:36 AM, Jean-Baptiste Onofré
wrote:
> -1 (binding)
>
> I would include the fix for metrics and impacting dataflow and flink
> runners.
>
> I agree with Davor: I
-1 (binding)
I would include the fix for metrics and impacting dataflow and flink runners.
I agree with Davor: I would prefer to cut a RC2.
Regards
JB
On Dec 15, 2016, 20:06, at 20:06, Kenneth Knowles
wrote:
>Agreed. I had though the issue in PR #1620 only affected
Agreed. I had though the issue in PR #1620 only affected Dataflow (in which
case we could address it in the service) but it now also affects the Flink
runner, so it should be included in the release.
On Thu, Dec 15, 2016 at 10:46 AM, Eugene Kirpichov <
kirpic...@google.com.invalid> wrote:
>
There is one more data-loss type error, a fix for which should go into the
release.
https://github.com/apache/incubator-beam/pull/1620
On Thu, Dec 15, 2016 at 10:42 AM Davor Bonaci wrote:
> I think we should build another RC.
>
> Two issues:
> * Metrics issue that JB pointed
I think we should build another RC.
Two issues:
* Metrics issue that JB pointed out earlier. It seems to cause a somewhat
poor user experience for every pipeline executed on the Direct runner.
(Thanks JB for finding this out!)
* Failure of testSideInputsWithMultipleWindows in Jenkins [1].
Both
Hi Amit,
thanks for the update.
As you changed the Jira, the Release Notes are now up to date.
Regards
JB
On 12/15/2016 02:20 PM, Amit Sela wrote:
I see three problems in the release notes (related to Spark runner):
Improvement:
[BEAM-757] - The SparkRunner should utilize the SDK's
I see three problems in the release notes (related to Spark runner):
Improvement:
[BEAM-757] - The SparkRunner should utilize the SDK's DoFnRunner instead of
writing it's own.
[BEAM-807] - [SparkRunner] Replace OldDoFn with DoFn
[BEAM-855] - Remove the need for --streaming option
Reviewing and testing the release, I see:
16/12/15 14:04:47 ERROR MetricsContainer: Unable to update metrics on
the current thread. Most likely caused by using metrics outside the
managed work-execution thread.
It doesn't block the execution of the pipeline, but basically, it means
that