[GitHub] bigtop issue #251: BIGTOP-2835: puppet fails when bigtop::jdk_preinstalled i...

2017-08-03 Thread kwmonroe
Github user kwmonroe commented on the issue: https://github.com/apache/bigtop/pull/251 This landed in master with the following commit: https://github.com/apache/bigtop/commit/40e796bd693a8bc6243ee39a6540357e1d559ea8 Closing out this PR. --- If your project is set u

[GitHub] bigtop issue #251: BIGTOP-2835: puppet fails when bigtop::jdk_preinstalled i...

2017-07-20 Thread evans-ye
Github user evans-ye commented on the issue: https://github.com/apache/bigtop/pull/251 LGTM. Thanks for the fix @kwmonroe! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] bigtop issue #251: BIGTOP-2835: puppet fails when bigtop::jdk_preinstalled i...

2017-07-08 Thread kwmonroe
Github user kwmonroe commented on the issue: https://github.com/apache/bigtop/pull/251 @c0s, thanks for taking a look! FYI, hadoop (various classes), zookeeper, and zeppelin will fail to deploy with `jdk_preinstalled: True` without this commit. They require `Package[jdk]`:

[GitHub] bigtop issue #251: BIGTOP-2835: puppet fails when bigtop::jdk_preinstalled i...

2017-07-07 Thread c0s
Github user c0s commented on the issue: https://github.com/apache/bigtop/pull/251 Looks logical and elegant. +1 (w/o any testing_ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature