+
1
(
n
o
n
b
i
n
d
i
n
g
)
On Fri, Jun 9, 2017 at 3:47 AM, Sijie Guo wrote:
> (dropping general@)
>
> - Sijie
>
> On Thu, Jun 8, 2017 at 5:21 PM, Sijie Guo wrote:
>
> > ( /cc bookkeeper dev@ and
[
https://issues.apache.org/jira/browse/BOOKKEEPER-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047305#comment-16047305
]
ASF GitHub Bot commented on BOOKKEEPER-1097:
GitHub user reddycharan opened a pull
GitHub user reddycharan opened a pull request:
https://github.com/apache/bookkeeper/pull/188
BOOKKEEPER-1097: GC test when no WritableDirs
- Functional test validating that Compaction takes place even if there
are no writableledgerdir but there are ledgerdirs according to
Charan Reddy Guttapalem created BOOKKEEPER-1097:
---
Summary: GC test when no WritableDirs
Key: BOOKKEEPER-1097
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1097
Project:
[
https://issues.apache.org/jira/browse/BOOKKEEPER-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047193#comment-16047193
]
ASF GitHub Bot commented on BOOKKEEPER-753:
---
Github user sijie commented on the issue:
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/81
@reddycharan sure. it happened to us before, that's why the code exists. I
am trying to reach a consensus on this change. If you guys are okay with this
change, I am going to rebase my change.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047169#comment-16047169
]
ASF GitHub Bot commented on BOOKKEEPER-753:
---
Github user reddycharan commented on the issue:
Github user reddycharan commented on the issue:
https://github.com/apache/bookkeeper/pull/81
@sijie ok, it is bit of an extreme case for it to happen (since
BookieStorageThreshold will be generally configured at safe levels) and even in
the case of eventuality (by misconfiguring or
[
https://issues.apache.org/jira/browse/BOOKKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047122#comment-16047122
]
ASF GitHub Bot commented on BOOKKEEPER-1028:
Github user reddycharan commented on the
Github user reddycharan commented on the issue:
https://github.com/apache/bookkeeper/pull/127
@eolivelli I fixed it. It seems this time it has passed. Boxing/unboxing
checks is new thing to me. Thanks for the follow up.
---
If your project is set up for it, you can reply to this
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/81
@reddycharan I've explained that above. in the case, you don't actually
have any physical disk space for compaction or open any new entry log files,
your approach still doesn't work. this patch is
Thanks Sijie and Flavio, will add above workflow part into the BP.
On Mon, Jun 12, 2017 at 2:26 PM, Sijie Guo wrote:
> On Mon, Jun 12, 2017 at 12:27 PM, Jia Zhai wrote:
>
> > Hi Enrico, Sijie And Flavio,
> >
> > Thanks a lot for the great comments on
[
https://issues.apache.org/jira/browse/BOOKKEEPER-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047104#comment-16047104
]
ASF GitHub Bot commented on BOOKKEEPER-753:
---
Github user reddycharan commented on the issue:
Github user reddycharan commented on the issue:
https://github.com/apache/bookkeeper/pull/81
your changes might not be required, because we are letting Bookie to start
in RO only mode when disks are full and within gcWaitTime period it will do gc
anyhow. Also, with your change it
On Mon, Jun 12, 2017 at 12:27 PM, Jia Zhai wrote:
> Hi Enrico, Sijie And Flavio,
>
> Thanks a lot for the great comments on this. the BP have changed following
> the comments.
>
> ```
> I think the labels/milestones can work as you described, but maybe we can
> consider to
Hi -
I am adding the Pulsar Dev list so that podling can be certainly aware. (I know
that there are BookKeeper dev involved in Pulsar.
Please drop general@ off for any further discussions from the Pulsar side.
Regards,
Dave
> On Jun 8, 2017, at 5:21 PM, Sijie Guo wrote:
>
[
https://issues.apache.org/jira/browse/BOOKKEEPER-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046982#comment-16046982
]
ASF GitHub Bot commented on BOOKKEEPER-753:
---
Github user sijie commented on the issue:
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/81
@reddycharan yes. I think the features can co-exist. I think the question
is - are you guys okay with this change? I am trying to move on merging
twitter's branch.
---
If your project is set up
Hi Enrico, Sijie And Flavio,
Thanks a lot for the great comments on this. the BP have changed following
the comments.
```
I think the labels/milestones can work as you described, but maybe we can
consider to use composite labels like component/server or type/improvement.
```
< == seems "server"
[
https://issues.apache.org/jira/browse/BOOKKEEPER-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046967#comment-16046967
]
ASF GitHub Bot commented on BOOKKEEPER-753:
---
Github user reddycharan commented on the issue:
Thanks for putting this together, Jia.
> If a change is trivial, or you have the code ready, you
> can open a PR directly; otherwise create an issue for
> discussion before starting writing code.
This is one of those things that sound like a good idea initially, but then
judging whether we
[
https://issues.apache.org/jira/browse/BOOKKEEPER-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046685#comment-16046685
]
ASF GitHub Bot commented on BOOKKEEPER-1089:
Github user sijie commented on the issue:
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/181
rebased to latest master, waiting for CI to complete
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/BOOKKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046667#comment-16046667
]
ASF GitHub Bot commented on BOOKKEEPER-1096:
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/BOOKKEEPER-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sijie Guo resolved BOOKKEEPER-1096.
---
Resolution: Fixed
Fix Version/s: 4.5.0
Issue resolved by merging pull request 186
Github user asfgit closed the pull request at:
https://github.com/apache/bookkeeper/pull/186
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
26 matches
Mail list logo