Re: [DISCUSS] Dropping Twitter modules

2020-01-04 Thread David Rusek
Hey sorry, still on vacation I thought I did approve it, sorry. On Fri, Jan 3, 2020 at 9:45 PM Sijie Guo wrote: > LGTM. +1 > > On Fri, Jan 3, 2020 at 10:25 PM Enrico Olivelli > wrote: > > > Thank you Dave > > > > can you please "Approve" the pull request ? > > Unfortunately Travis has problems

Re: [DISCUSS] Dropping Twitter modules

2020-01-03 Thread Sijie Guo
LGTM. +1 On Fri, Jan 3, 2020 at 10:25 PM Enrico Olivelli wrote: > Thank you Dave > > can you please "Approve" the pull request ? > Unfortunately Travis has problems and the build fails, I have started > another thread to fix the problem > > Enrico > > Il giorno ven 3 gen 2020 alle ore 15:24 Davi

Re: [DISCUSS] Dropping Twitter modules

2020-01-03 Thread Enrico Olivelli
Thank you Dave can you please "Approve" the pull request ? Unfortunately Travis has problems and the build fails, I have started another thread to fix the problem Enrico Il giorno ven 3 gen 2020 alle ore 15:24 David Rusek ha scritto: > Confirming what I said on slack, it’s not worth us maintai

Re: [DISCUSS] Dropping Twitter modules

2020-01-03 Thread David Rusek
Confirming what I said on slack, it’s not worth us maintaining these modules. On Fri, Jan 3, 2020 at 5:54 AM Jia Zhai wrote: > +1 to remove it. > > Best Regards. > > > Jia Zhai > > Beijing, China > > Mobile: +86 15810491983 > > > > > On Fri, Jan 3, 2020 at 6:37 PM Enrico Olivelli > wrote: > >>

Re: [DISCUSS] Dropping Twitter modules

2020-01-03 Thread Jia Zhai
+1 to remove it. Best Regards. Jia Zhai Beijing, China Mobile: +86 15810491983 On Fri, Jan 3, 2020 at 6:37 PM Enrico Olivelli wrote: > This is the patch > https://github.com/apache/bookkeeper/pull/2232 > > @Sijie @Dave please take a look > > Enrico > > Il giorno ven 3 gen 2020 alle ore 1

Re: [DISCUSS] Dropping Twitter modules

2020-01-03 Thread Enrico Olivelli
This is the patch https://github.com/apache/bookkeeper/pull/2232 @Sijie @Dave please take a look Enrico Il giorno ven 3 gen 2020 alle ore 11:00 Enrico Olivelli ha scritto: > Hi, > on slack Dave Rusek told me it is useless to keep this stuff. > It seems that he did not receive this message, I a

Re: [DISCUSS] Dropping Twitter modules

2020-01-03 Thread Enrico Olivelli
Hi, on slack Dave Rusek told me it is useless to keep this stuff. It seems that he did not receive this message, I am posting this message just to let him confirm btw I am preparing a patch that drops all of this stuff Enrico Enrico Il giorno sab 28 dic 2019 alle ore 09:52 Enrico Olivelli < eol

[DISCUSS] Dropping Twitter modules

2019-12-28 Thread Enrico Olivelli
Hi folks, I propose to drop the four modules that contain Twitter specific stuff. Those modules did not receive changes for long time, nor issues/questions from users. We recently added a new Maven profile (-Dtwitter) to skip them from build. The modules are: - Http Server: https://github.com/apa