Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/180
@merlimat ??
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/180
you still need to call "readLastAddConfirmed". This change is not "long
poll", it is "piggy-back lac". It is an optimization on reducing the times of
calling readLastAddConfirmed. In a tailing
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/180
@sijie I did a more deep review and it is all great for me.
Do you think it would be useful to add a test for readUnconfirmedEntries ?
Actually the implementation is shared with
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/180
@merlimat review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
