[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-06-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/183 fyi, I added @merlimat and me to the reviewers list, making sure we have other eyes on reviewing this change. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-06-28 Thread sijie
Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/183 @eolivelli I will try to go through this again. /cc @merlimat for reviewing as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-06-26 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/183 @sijie for me this patch is OK, I don't know if other developers/committer want to add other comments @kishorekasi can you change the description of the PR which usually it written to

[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-06-25 Thread kishorekasi
Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/183 Updated the pull request. I am not able to reproduced the previous jenkins failure locally. With this new update I will wait for the jenkins run to check if the failures are repeatable. ---

[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-06-15 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/183 Overall is ok, but rat is failing and on jenkins one of the new tests failed, the mixed cluster one Can you fix it? --- If your project is set up for it, you can reply to this em

[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-06-09 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/183 I wonder if we have to add some "stat" about SSL clients. Maybe we can enhance this aspect in the future --- If your project is set up for it, you can reply to this email and have your reply a