Re: Review Request 28835: BOOKKEEPER-634: Provide admin tool to rename bookie identifier in ledger metadata

> On Dec. 18, 2014, 5:54 a.m., Sijie Guo wrote: > > bookkeeper-server/src/main/java/org/apache/bookkeeper/client/UpdateLedgerOp.java, > > line 118 > > > > > > why you need #get() here? isn't Runnable called only when

Re: Review Request 28835: BOOKKEEPER-634: Provide admin tool to rename bookie identifier in ledger metadata

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28835/ --- (Updated Dec. 21, 2014, 5:52 p.m.) Review request for bookkeeper, fpj, Ivan Kel

Re: Review Request 28835: BOOKKEEPER-634: Provide admin tool to rename bookie identifier in ledger metadata

> On Dec. 18, 2014, 5:54 a.m., Sijie Guo wrote: > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java, > > line 1190 > > > > > > final done > On Dec. 18, 2014, 5:54 a.m., Sijie Guo wrot