Re: Last issues before cutting 4.10

2019-10-03 Thread Enrico Olivelli
Il gio 3 ott 2019, 23:52 Karan Mehta ha scritto: > I see that you concluded on this issue > with comment here > , > however have we actually added any Javadoc for it? >

Re: Last issues before cutting 4.10

2019-10-03 Thread Karan Mehta
I see that you concluded on this issue with comment here , however have we actually added any Javadoc for it? On Wed, Oct 2, 2019 at 1:09 AM Enrico Olivelli wrote: > Hi,

Re: Apache Bookkeeper Checksum Validation

2019-10-03 Thread Karan Mehta
Thanks for the feedback. I will create a BP soon. > I won't shutdown the bookie, simply fail the write. It may happen in case of a partial upgrade of the cluster and a write with a new digest type comes to the bookie Interesting point. As per my assumptions, `All the options assume that the

Re: Apache Bookkeeper Checksum Validation

2019-10-03 Thread Enrico Olivelli
Thank you for sharing this work. Two initial comments: Error handling: Unable to instantiate digest manager for that type Decline the write, shutdown itself and wait for external orchestrator to restart I won't shutdown the bookie, simply fail the write. It may happen in case of a partial

Re: Apache Bookkeeper Checksum Validation

2019-10-03 Thread Sijie Guo
Hi Karan, Thank you for your proposal. Can you also add your proposal as a BP to the BP list? You can check the BP process here: http://bookkeeper.apache.org/community/bookkeeper_proposals/ Thanks, Sijie On Fri, Sep 27, 2019 at 5:53 AM Karan Mehta wrote: > Hello everyone, > > I wrote up a