Re: Question regarding force compaction/GC logic in GarbageCollectorThread.java

2017-02-07 Thread Sijie Guo
On Tue, Feb 7, 2017 at 10:56 PM, Charan Reddy G wrote: > Thanks Sijie, for the clarification. So going by Twitter's code, you intend > to run force Major/Minor compaction only once when enableForceGC is called. > Can you please confirm that (which is different from

Re: Question regarding force compaction/GC logic in GarbageCollectorThread.java

2017-02-07 Thread Sijie Guo
The forceGarbageCollection was contributed by Twitter before. I remembered we wrapped that into a try-finally block. I just checked Twitter's branch. We did wrap that in a try-finally block.