[GitHub] incubator-brooklyn pull request: reorganise project structure in p...

2015-12-22 Thread geomacy
Github user geomacy commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1119#issuecomment-166637869 I have a couple of questions - 1. Why do we have a relativeRoot in the pom files - shouldn't we avoid ".." in the poms and rely on the maven

[GitHub] incubator-brooklyn pull request: reorganise project structure in p...

2015-12-22 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1119#issuecomment-166645937 @geomacy the parent defines the profiles for integration tests and releases which is common to nearly all brooklyn projects. and the way maven handles

[GitHub] incubator-brooklyn pull request: reorganise project structure in p...

2015-12-22 Thread geomacy
Github user geomacy commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1119#issuecomment-166647110 Fair enough thanks @ahgittin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-brooklyn pull request: reorganise project structure in p...

2015-12-22 Thread johnmccabe
Github user johnmccabe commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1119#issuecomment-166649934 @sjcorbett @ahgittin are these intermittent failures only seen during runs on Jenkins or have you encountered then running locally? --- If your

[GitHub] incubator-brooklyn pull request: reorganise project structure in p...

2015-12-22 Thread sjcorbett
Github user sjcorbett commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1119#issuecomment-166646696 @ahgittin There are a few unreliable tests on Jenkins. See https://issues.apache.org/jira/browse/BROOKLYN-203,

[jira] [Commented] (BROOKLYN-203) Unpredictable test: ControlledDynamicWebAppClusterTest.testTheTestJavaWebApp

2015-12-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068255#comment-15068255 ] ASF GitHub Bot commented on BROOKLYN-203: - Github user sjcorbett commented on the pull request:

[GitHub] incubator-brooklyn pull request: reorganise project structure in p...

2015-12-22 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1119#issuecomment-166646159 unusual failure, `ControlledDynamicWebAppCluster.testTheJavaWebApp()`, sensor timeout; seems spurious, will try again shortly /cc @aledsage --- If your

[GitHub] incubator-brooklyn pull request: reorganise project structure in p...

2015-12-22 Thread sjcorbett
Github user sjcorbett commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1119#issuecomment-166650192 @johnmccabe I've seen 204 locally once or twice, none of the others. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-brooklyn pull request: Add CLI documentation to the Oper...

2015-12-22 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1118#discussion_r48284869 --- Diff: docs/guide/ops/cli/cli-ref-guide.md --- @@ -0,0 +1,310 @@ +--- +title: CLI Reference Guide +layout: website-normal

[GitHub] incubator-brooklyn pull request: Add CLI documentation to the Oper...

2015-12-22 Thread johnmccabe
Github user johnmccabe commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1118#discussion_r48284423 --- Diff: docs/guide/ops/cli/cli-ref-guide.md --- @@ -0,0 +1,310 @@ +--- +title: CLI Reference Guide +layout: website-normal

[GitHub] incubator-brooklyn pull request: DO NOT MERGE - "Getting Started" ...

2015-12-22 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1116#discussion_r48308809 --- Diff: docs/guide/start/policies-cli.md --- @@ -0,0 +1,172 @@ +--- +title: Getting Started - Policies +title_in_menu: Policies

[GitHub] incubator-brooklyn pull request: Test correct persistence of attri...

2015-12-22 Thread googlielmo
Github user googlielmo commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1120#discussion_r48301440 --- Diff: usage/camp/src/test/java/org/apache/brooklyn/camp/brooklyn/DslAndRebindYamlTest.java --- @@ -124,6 +126,19 @@ public void

[GitHub] incubator-brooklyn pull request: DO NOT MERGE - "Getting Started" ...

2015-12-22 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1116#discussion_r48308867 --- Diff: docs/guide/start/blueprints-cli.md --- @@ -0,0 +1,80 @@ +--- +title: Deploying Blueprints +layout: website-normal

Launching multiple apps when starting Brooklyn

2015-12-22 Thread Abhishek Sharma
Hey guys, I am trying to make Brooklyn start my node.js web application and also a drop-wizard based java service. I am using Java Blueprints and not YAML. How do I make brooklyn start multiple applications ? My goal is to start these based on a command line parameters passed when starting

[GitHub] incubator-brooklyn pull request: reorganise project structure in p...

2015-12-22 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1119#issuecomment-12490 thx @sjcorbett , you're on top of it. it was BROOKLYN-203 which we saw here. never seen that before. --- If your project is set up for it, you can

[GitHub] incubator-brooklyn pull request: DO NOT MERGE - "Getting Started" ...

2015-12-22 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1116#discussion_r48238024 --- Diff: docs/guide/start/managing-cli.md --- @@ -0,0 +1,309 @@ +--- +title: Monitoring and Managing Applications +title_in_menu:

[GitHub] incubator-brooklyn pull request: Add CLI documentation to the Oper...

2015-12-22 Thread lloyddave
Github user lloyddave commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1118#issuecomment-166582966 @ahgittin @shartzel Updates completed and commits squashed. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-brooklyn pull request: Add CLI documentation to the Oper...

2015-12-22 Thread lloyddave
Github user lloyddave commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1118#discussion_r48237080 --- Diff: docs/guide/ops/cli/cli-ref-guide.md --- @@ -0,0 +1,310 @@ +--- +title: CLI Reference Guide +layout: website-normal

[GitHub] incubator-brooklyn pull request: DO NOT MERGE - "Getting Started" ...

2015-12-22 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1116#discussion_r48233928 --- Diff: docs/guide/start/blueprints-cli.md --- @@ -0,0 +1,80 @@ +--- +title: Deploying Blueprints +layout: website-normal

[GitHub] incubator-brooklyn pull request: reorganise project structure in p...

2015-12-22 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1119#issuecomment-166590578 awesome job. works great so far and should really simplify the migration, as much as we can. great summary as well @johnmccabe. i've been

[GitHub] incubator-brooklyn pull request: Test correct persistence of attri...

2015-12-22 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1120#discussion_r48272017 --- Diff: usage/camp/src/test/java/org/apache/brooklyn/camp/brooklyn/DslAndRebindYamlTest.java --- @@ -124,6 +126,19 @@ public void

[GitHub] incubator-brooklyn pull request: Test correct persistence of attri...

2015-12-22 Thread googlielmo
GitHub user googlielmo opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1120 Test correct persistence of attributeWhenReady An entity with an instance of `attributeWhenReady` is serialised and then deserialised You can merge this pull request into a Git

[jira] [Commented] (BROOKLYN-203) Unpredictable test: ControlledDynamicWebAppClusterTest.testTheTestJavaWebApp

2015-12-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068324#comment-15068324 ] ASF GitHub Bot commented on BROOKLYN-203: - Github user ahgittin commented on the pull request:

[GitHub] incubator-brooklyn pull request: reorganise project structure in p...

2015-12-22 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1119#issuecomment-166671921 | tests - some tests are taking a long time as discussed -- to be fixed later but not in this PR | poms - library repeats versions from

[GitHub] incubator-brooklyn pull request: reorganise project structure in p...

2015-12-22 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1119#issuecomment-166633378 have looked in to why tests are taking significantly longer. i fixed a few obvious items, but there seem to be two recent big offenders: * test

[GitHub] incubator-brooklyn pull request: Various QA changes

2015-12-22 Thread Graeme-Miller
Github user Graeme-Miller commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1115#issuecomment-166632121 @ahgittin docs updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-brooklyn pull request: Add CLI documentation to the Oper...

2015-12-22 Thread ahgittin
Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1118#issuecomment-166678237 great stuff, will merge (but might do #1119 first) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-brooklyn pull request: reorganise project structure in p...

2015-12-22 Thread johnmccabe
Github user johnmccabe commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1119#issuecomment-166686154 :+1: lgtm, builds and tests passing, just a few trivial observations/comments. --- If your project is set up for it, you can reply to this email and

[jira] [Created] (BROOKLYN-208) Config resolution on shutdown

2015-12-22 Thread Graeme Miller (JIRA)
Graeme Miller created BROOKLYN-208: -- Summary: Config resolution on shutdown Key: BROOKLYN-208 URL: https://issues.apache.org/jira/browse/BROOKLYN-208 Project: Brooklyn Issue Type: Bug

[jira] [Commented] (BROOKLYN-208) Config resolution on shutdown

2015-12-22 Thread Sam Corbett (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068464#comment-15068464 ] Sam Corbett commented on BROOKLYN-208: -- Mike recently worked on this problem too: