[GitHub] incubator-brooklyn pull request: Test correct persistence of attri...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1120#discussion_r48551193 --- Diff: brooklyn-server/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/DslAndRebindYamlTest.java --- @@ -83,15 +95,14 @@

[GitHub] incubator-brooklyn pull request: JcloudsLocation: fix waitForWinRm...

Github user bostko commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r48562878 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -1608,7 +1606,35 @@ protected

[GitHub] incubator-brooklyn pull request: Update for using a file for compl...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-brooklyn pull request: Fix `VaultAppIdExternalConfigSupp...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Build failed in Jenkins: incubator-brooklyn-master-windows #391

See Changes: [valentin.aitken] Fix `VaultAppIdExternalConfigSupplier` dynamic constructor [david] Update for using a file for complex / multi-line invoke parameter --

[GitHub] incubator-brooklyn pull request: JcloudsLocation: fix waitForWinRm...

Github user bostko commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r48562111 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -1608,7 +1606,35 @@ protected

[GitHub] incubator-brooklyn pull request: Test correct persistence of attri...

Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1120#issuecomment-167899413 See suggested additional tests, and alterations to tests, in https://github.com/googlielmo/incubator-brooklyn/pull/2 --- If your project is set up for