[GitHub] brooklyn-library issue #53: Do not merge, for review: Move karaf distributio...

2016-07-26 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-library/pull/53 Review comments applied, squashed and pushed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-server issue #271: Do not merge, for review: Move karaf distributio...

2016-07-26 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/271 Review comments applied, squashed and pushed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-dist pull request #41: Do not merge, for review: Move karaf distrib...

2016-07-26 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/41#discussion_r72348289 --- Diff: dist-karaf/apache-brooklyn/src/main/resources/etc/default.catalog.bom --- @@ -0,0 +1,371 @@ + +# this catalog bom is an illustration

Re: Merge brooklyn.parameters in YAML files

2016-07-26 Thread Andrew Kennedy
One thing to note in the latest commit on the PR is that I made some changes suggested by @neykov to always add the configuration from the entity as parameters, and also to *prepend* new parameters. That means that in the UI, the list of parameters will be sorted in the reverse order of entity

[GitHub] brooklyn-server pull request #274: Load default exception mapper in web.xml

2016-07-26 Thread grkvlt
GitHub user grkvlt opened a pull request: https://github.com/apache/brooklyn-server/pull/274 Load default exception mapper in web.xml You can merge this pull request into a Git repository by running: $ git pull https://github.com/grkvlt/brooklyn-server stop-404-error-log

[GitHub] brooklyn-server issue #229: Merge brooklyn.parameters in YAML files

2016-07-26 Thread grkvlt
Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-server/pull/229 See [message](http://mail-archives.apache.org/mod_mbox/brooklyn-dev/201607.mbox/%3CCAEK0Ph2S4WJ7pV6XNr21wJGPfikX5tQYgm3at1dNDoBwoacy6Q%40mail.gmail.com%3E) on

[GitHub] brooklyn-server issue #229: Merge brooklyn.parameters in YAML files

2016-07-26 Thread grkvlt
Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-server/pull/229 @neykov I implemented your suggestion (first add from spec if no spec parameters then merge with explicit parameters) and it also now places the current entities params at the start of the

Merge brooklyn.parameters in YAML files

2016-07-26 Thread Andrew Kennedy
- https://github.com/apache/brooklyn-server/pull/229 I have created this PR to fix an issue with the handling of brooklyn.parameters in BOM files. We now merge config keys and maps, so it is expected that an entity will have its configuration be the union of the config of its ancestors, with the

[jira] [Commented] (BROOKLYN-302) SSLException: close_notify in ResourceUtils getResourceAsString against https url

2016-07-26 Thread Duncan Grant (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393751#comment-15393751 ] Duncan Grant commented on BROOKLYN-302: --- Looks like this can happen if you are on virginmedia and

[GitHub] brooklyn-library pull request #53: Do not merge, for review: Move karaf dist...

2016-07-26 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/53#discussion_r72228679 --- Diff: karaf/features/pom.xml --- @@ -0,0 +1,60 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] brooklyn-docs issue #97: Improves examples copy-ability

2016-07-26 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-docs/pull/97 LGTM :thumbsup: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] brooklyn-server pull request #271: Do not merge, for review: Move karaf dist...

2016-07-26 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/271#discussion_r72227840 --- Diff: karaf/features/src/main/feature/feature.xml --- @@ -276,60 +276,6 @@ jclouds-api-filesystem

[jira] [Comment Edited] (BROOKLYN-302) SSLException: close_notify in ResourceUtils getResourceAsString against https url

2016-07-26 Thread Geoff Macartney (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393614#comment-15393614 ] Geoff Macartney edited comment on BROOKLYN-302 at 7/26/16 10:45 AM:

[jira] [Comment Edited] (BROOKLYN-302) SSLException: close_notify in ResourceUtils getResourceAsString against https url

2016-07-26 Thread Geoff Macartney (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393614#comment-15393614 ] Geoff Macartney edited comment on BROOKLYN-302 at 7/26/16 10:46 AM:

[jira] [Commented] (BROOKLYN-302) SSLException: close_notify in ResourceUtils getResourceAsString against https url

2016-07-26 Thread Geoff Macartney (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393614#comment-15393614 ] Geoff Macartney commented on BROOKLYN-302: -- I had a very similar problem when running container