[GitHub] brooklyn-server issue #280: Add special flag decoration to parameters to ena...

Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-server/pull/280 @aledsage The "no adapter known" error is exactly what I was getting, that prompted this change. Thanks for the test code, I have added it as you suggested, and it passes as expected. This

[GitHub] brooklyn-server pull request #279: Allow provisioning.properties to referenc...

Github user grkvlt commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/279#discussion_r74532002 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -49,6 +50,68 @@ import

[GitHub] brooklyn-server issue #291: Conveniences to make groups easier to configure ...

Github user alasdairhodge commented on the issue: https://github.com/apache/brooklyn-server/pull/291 Just one other thing: do we have a naming convention for config keys? Don't want to start a religious war over the camelCase `factoryMethod` ;o) --- If your project is set up for it,

[GitHub] brooklyn-server pull request #291: Conveniences to make groups easier to con...

Github user alasdairhodge commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/291#discussion_r74521683 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/BrooklynDslCommon.java --- @@ -327,25 +337,74 @@

[GitHub] brooklyn-server pull request #292: Shared location customizer

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/292#discussion_r74505875 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java --- @@ -0,0

[GitHub] brooklyn-server pull request #292: Shared location customizer

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/292#discussion_r74505759 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java --- @@ -0,0

[GitHub] brooklyn-server issue #292: Shared location customizer

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/292 @duncangrant there are merge conflicts - can you rebase against master please? (Jenkins won't run the tests until that conflict is resolved). --- If your project is set up for it, you can

[GitHub] brooklyn-server pull request #298: Add BrooklynNetworkUtils.portRulesToRange...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #137: FOR REVIEW: easier access for entity config by n...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/137 @alasdairhodge can you rebase this please so we can see if all the tests pass? I'm still not sure about us calling `deferredSupplier.get()` inside coerce. I have a couple of big

[GitHub] brooklyn-server issue #279: Allow provisioning.properties to reference resol...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/279 @grkvlt you said that you'd "add some more [tests] to illustrate the use of resolvable entity config in a jclouds location context". Is that something you plan to do for this PR? Do you

[GitHub] brooklyn-server pull request #279: Allow provisioning.properties to referenc...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/279#discussion_r74495798 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -49,6 +50,68 @@ import

[GitHub] brooklyn-server issue #280: Add special flag decoration to parameters to ena...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/280 The failing jenkins test looks unrelated - `LoadBalancingPolicySoakTest.testLoadBalancingQuickTest`. We really need to deal with that one! --- If your project is set up for it, you can

[GitHub] brooklyn-server issue #280: Add special flag decoration to parameters to ena...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/280 @grkvlt when will you have a chance to look at this PR again? I tried writing a test for you (adding it to `ConfigParametersYamlTest`), but it fails: ``` @Test

[GitHub] brooklyn-server pull request #292: Shared location customizer

Github user duncangrant commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/292#discussion_r74493525 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java --- @@

[GitHub] brooklyn-server pull request #292: Shared location customizer

Github user duncangrant commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/292#discussion_r74493342 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java --- @@

[GitHub] brooklyn-server issue #281: Prevent VanillaSoftwareProcess commands from bei...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/281 @grkvlt will you get a chance to look at this again soon? Hopefully the tests I wrote and pasted into the comment will work for you. They certainly failed in the right way without

[GitHub] brooklyn-server issue #291: Conveniences to make groups easier to configure ...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/291 @alasdairhodge looks good. Just one comment that I'm interested in before this is merged: what is the purpose of calling `TypeCoercions.coerce(fields, type)`? --- If your project is set

[GitHub] brooklyn-server pull request #291: Conveniences to make groups easier to con...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/291#discussion_r74491248 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/BrooklynDslCommon.java --- @@ -384,24 +445,48 @@

[GitHub] brooklyn-server pull request #291: Conveniences to make groups easier to con...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/291#discussion_r74489795 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/BrooklynDslCommon.java --- @@ -327,25 +337,74 @@

[GitHub] brooklyn-server pull request #296: Various minor things

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/296 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #296: Various minor things

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/296 Thanks @neykov - incorporated comments and squashed. Merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] brooklyn-server pull request #292: Shared location customizer

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/292#discussion_r74480881 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizerTest.java --- @@

[GitHub] brooklyn-server pull request #292: Shared location customizer

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/292#discussion_r74479809 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java --- @@ -0,0

[GitHub] brooklyn-server pull request #292: Shared location customizer

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/292#discussion_r74463540 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java --- @@ -0,0

[GitHub] brooklyn-server pull request #292: Shared location customizer

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/292#discussion_r74463259 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java --- @@ -0,0

[GitHub] brooklyn-server pull request #292: Shared location customizer

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/292#discussion_r74462757 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java --- @@ -0,0

[GitHub] brooklyn-server pull request #292: Shared location customizer

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/292#discussion_r74462321 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java --- @@ -0,0

[GitHub] brooklyn-server pull request #292: Shared location customizer

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/292#discussion_r74462257 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SharedLocationSecurityGroupCustomizer.java --- @@ -0,0

Re: [PROPOSAL] $brooklyn:attributeWhenReady semantics

Yes, what Svet said is exactly right. I want to know the status of a boolean sensor which can usefully be set to false. I think the behaviour is currently is rather surprising - well, it surprised me when I realised my blueprint didn't work because I was waiting on a false value! I'd be happy

Build failed in Jenkins: brooklyn-master-windows #233

See -- [...truncated 32850 lines...] [JENKINS] Recording test results [INFO] [INFO] Reactor Summary: [INFO] [INFO]

[GitHub] brooklyn-server issue #292: Shared location customizer

Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/292 @duncangrant I addressed @aledsage 's comments in my PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Build failed in Jenkins: brooklyn-master-windows #232

See -- [...truncated 32021 lines...] [JENKINS] Recording test results [INFO] [INFO] Reactor Summary: [INFO] [INFO]

[GitHub] brooklyn-server pull request #297: Add more assertions to SoftwareProcessEnt...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/297 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #297: Add more assertions to SoftwareProcessEntityFeed...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/297 Jenkins build successful - merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-server issue #297: Add more assertions to SoftwareProcessEntityFeed...

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/297 LGTM, will merge after jenkins confirms. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-server pull request #295: Change conditional entity to reflect serv...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/295#discussion_r74423357 --- Diff: core/src/main/java/org/apache/brooklyn/entity/stock/ConditionalEntityImpl.java --- @@ -19,25 +19,72 @@ package

[GitHub] brooklyn-server issue #287: Add new member tracking policy with configurable...

Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-server/pull/287 Thanks @neykov --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] brooklyn-server pull request #274: Load default exception mapper in web.xml

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/274 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request #297: Add more assertions to SoftwareProcessEnt...

GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/297 Add more assertions to SoftwareProcessEntityFeedRebindTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-server

[GitHub] brooklyn-server issue #274: Load default exception mapper in web.xml

Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-server/pull/274 @neykov I removed the `import` lines in `DefaultExceptionMapper.java` so I'm going to merge now --- If your project is set up for it, you can reply to this email and have your reply appear

Jenkins build is back to normal : brooklyn-server-master #217

See

[GitHub] brooklyn-server issue #296: Various minor things

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/296 Can be merged after fixing the `assertExecContains` -> `assertExecNotContains` name. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] brooklyn-server issue #287: Add new member tracking policy with configurable...

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/287 LGTM from me as well, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server issue #295: Change conditional entity to reflect service sta...

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/295 LGTM, could improve `SERVICE_UP` handling by following the `AbstractApplication` example. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server pull request #295: Change conditional entity to reflect serv...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/295#discussion_r74423092 --- Diff: core/src/main/java/org/apache/brooklyn/entity/stock/ConditionalEntityImpl.java --- @@ -19,25 +19,72 @@ package

[GitHub] brooklyn-server pull request #295: Change conditional entity to reflect serv...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/295#discussion_r74420188 --- Diff: core/src/main/java/org/apache/brooklyn/entity/stock/ConditionalEntityImpl.java --- @@ -19,25 +19,72 @@ package

[GitHub] brooklyn-server pull request #292: Shared location customizer

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/292#discussion_r74410438 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/BrooklynNetworkUtils.java --- @@ -19,24 +19,52 @@ package

[GitHub] brooklyn-server pull request #292: Shared location customizer

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/292#discussion_r74410202 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/BrooklynNetworkUtils.java --- @@ -19,24 +19,52 @@ package

Build failed in Jenkins: brooklyn-server-master #216

See Changes: [svetoslav.neykov] Move tests temporary folders to the target folder -- [...truncated 36127 lines...] Enrichers: Transformer{uniqueTag=service.isUp if no

[GitHub] brooklyn-server pull request #292: Shared location customizer

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/292#discussion_r74409198 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/BrooklynNetworkUtils.java --- @@ -19,24 +19,52 @@ package

[GitHub] brooklyn-server pull request #293: Move tests temporary folders to the targe...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/293 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #293: Move tests temporary folders to the target folde...

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/293 LGTM; merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] brooklyn-server issue #274: Load default exception mapper in web.xml

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/274 Changes look good. Can be merged after removing the changes for `DefaultExceptionMapper.java`. --- If your project is set up for it, you can reply to this email and have your reply appear