Re: External properties in Freemarker and Java

2017-03-28 Thread Alex Heneveld
I'm of the opinion that templates *shouldn't* access externals directly. Templates should be tied to an entity and so only rely on the config of that entity. You can then set a config key in YAML to have the external value and use that from the templates. In theory, this makes the

Re: External properties in Freemarker and Java

2017-03-28 Thread Valentin Aitken
Hi Graham, External config supplier is not supported out of the box for templates.install config. However I think I figured out a hacky solution similar to '$brooklyn:external' implementation which is in BrooklynDslCommon. DslExternal.

[GitHub] brooklyn-library issue #76: Tweak to password change effector so that sed id...

2017-03-28 Thread m4rkmckenna
Github user m4rkmckenna commented on the issue: https://github.com/apache/brooklyn-library/pull/76 @tbouron It would be better to create a pure yaml implementation of this blueprint --- If your project is set up for it, you can reply to this email and have your reply appear on

External properties in Freemarker and Java

2017-03-28 Thread Graham Ashby
So, I have a couple of external properties specified in brooklyn.properties in place: brooklyn.external.credentials=org.apache.brooklyn.core.config.external.InPlaceExternalConfigSupplier brooklyn.external.credentials.download_user=userID brooklyn.external.credentials.download_pass=BigSecret! I

[GitHub] brooklyn-server pull request #605: Add series of meta effectors for composit...

2017-03-28 Thread grkvlt
Github user grkvlt commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/605#discussion_r108466870 --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/composite/AbstractCompositeEffector.java --- @@ -0,0 +1,184 @@ +/* + *

[GitHub] brooklyn-library issue #8: Feature/paas cf support

2017-03-28 Thread andreaturli
Github user andreaturli commented on the issue: https://github.com/apache/brooklyn-library/pull/8 @kiuby88 thanks again for your effort. Same comment made at https://github.com/apache/brooklyn-server/pull/30#issuecomment-289792727 for this PR as well. Would you close this and

[GitHub] brooklyn-server issue #30: Feature/paas cf support

2017-03-28 Thread andreaturli
Github user andreaturli commented on the issue: https://github.com/apache/brooklyn-server/pull/30 @kiuby88 this is a long lasting PR which I don't think can be merged easily now. I also know this work has been very likely superseded by

[GitHub] brooklyn-library issue #76: Tweak to password change effector so that sed id...

2017-03-28 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-library/pull/76 @m4rkmckenna `Augeas` seems like a idea. Is it possible to update this blueprint to use this tool? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] brooklyn-server issue #589: yaml-test assertions: fix use of “matches”

2017-03-28 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/589 Just to add my 2c: I think it's better to let the user decide what the regex should match. There are 2 cases: 1. an author want to match pretty simple thing, i.e. most likely a simple

[GitHub] brooklyn-server issue #600: Adds perf test for xml serialiser (and memento-g...

2017-03-28 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/600 @aledsage Very cool, didn't know we had that in Brooklyn! Good idea to generalise this, would be very helpful. Tested locally, got similar results as yours: ``` 2017-03-28

[GitHub] brooklyn-server issue #546: Sequencer entity

2017-03-28 Thread grkvlt
Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-server/pull/546 @mikezaccardo is this still useful, e.g. for HLF blueprints? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] brooklyn-server issue #153: [WIP] Add support for JSR-223 scripting of effec...

2017-03-28 Thread grkvlt
Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-server/pull/153 Closing this, as much of the desired functionality can be obtained through use of the meta effectors in #605 --- If your project is set up for it, you can reply to this email and have your

[GitHub] brooklyn-server pull request #322: Adds a TargetServerEntity for improved co...

2017-03-28 Thread grkvlt
Github user grkvlt closed the pull request at: https://github.com/apache/brooklyn-server/pull/322 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #322: Adds a TargetServerEntity for improved command s...

2017-03-28 Thread grkvlt
Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-server/pull/322 This can actually be implemented by adding a child to an entity with a latch that prevents startup until some other entity is available, so closing --- If your project is set up for it, you

[jira] [Resolved] (BROOKLYN-196) Fix and re-enable ApiResourceTest tests

2017-03-28 Thread Svetoslav Neykov (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Svetoslav Neykov resolved BROOKLYN-196. --- Resolution: Fixed Assignee: (was: Ciprian Ciubotariu) > Fix and re-enable

[jira] [Commented] (BROOKLYN-161) Use generated test bundles

2017-03-28 Thread Svetoslav Neykov (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945046#comment-15945046 ] Svetoslav Neykov commented on BROOKLYN-161: --- Tests are passing successfully now, closing. >

[GitHub] brooklyn-server issue #600: Adds perf test for xml serialiser (and memento-g...

2017-03-28 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/600 @tbouron I changed the xml-serializer configuration (see https://github.com/apache/brooklyn-server/pull/593#discussion_r105950198) and didn't know what the performance implications would

[GitHub] brooklyn-server issue #600: Adds perf test for xml serialiser (and memento-g...

2017-03-28 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/600 What is the use case for this @aledsage ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-server pull request #611: Deprecate groovy

2017-03-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/611#discussion_r108373185 --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/MethodEffector.java --- @@ -133,6 +133,10 @@ public MethodEffector(Method method) {

[GitHub] brooklyn-server pull request #611: Deprecate groovy

2017-03-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/611#discussion_r108372912 --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/ExplicitEffector.java --- @@ -46,12 +58,20 @@ public T call(Entity entity, Map

[GitHub] brooklyn-server pull request #611: Deprecate groovy

2017-03-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/611#discussion_r108374329 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessImpl.java --- @@ -476,6 +476,11 @@ public void

[GitHub] brooklyn-server pull request #608: `BundleMaker` REST call allowing to add Z...

2017-03-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/608#discussion_r108382104 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java --- @@ -0,0 +1,180 @@ +/* + * Licensed to

[GitHub] brooklyn-server pull request #613: Returns catalog items created via REST AP...

2017-03-28 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/613#discussion_r108380227 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/CatalogResource.java --- @@ -146,33 +146,15 @@ public Response

[jira] [Commented] (BROOKLYN-456) "SSLException: internal_error" upon trying to connect to site requiring SNI

2017-03-28 Thread Mark McKenna (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944861#comment-15944861 ] Mark McKenna commented on BROOKLYN-456: --- [~geomacy] h3. Minimal Http Client (above) {code} ***

[GitHub] brooklyn-server pull request #612: Brooklyn Camp syntax for adding tags to a...

2017-03-28 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/612#discussion_r108371784 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java --- @@ -230,4

[jira] [Commented] (BROOKLYN-456) "SSLException: internal_error" upon trying to connect to site requiring SNI

2017-03-28 Thread Geoff Macartney (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944833#comment-15944833 ] Geoff Macartney commented on BROOKLYN-456: -- Looks good [~m4rkmckenna], definitely there's